Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Descriptor #14138

Closed
wants to merge 1 commit into from
Closed

Refactor Descriptor #14138

wants to merge 1 commit into from

Commits on Nov 8, 2016

  1. Refactor Descriptor 

    * Duck-type on `isDescriptor === true` instead of using `instanceof`
* Require all descriptors to have `setup` and `teardown`
* Refactored most descriptors to use ES6 classes except CP descriptors
  because it’s a big file and I ran out of time for it
    @chancancode @locks
    chancancode authored and locks committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    66bb37f View commit details
    Browse the repository at this point in the history