Skip to content

Fix develop validation cleanup - #12924

Closed
lalalune wants to merge 26 commits into
developfrom
fix/develop-validation-cleanup
Closed

Fix develop validation cleanup#12924
lalalune wants to merge 26 commits into
developfrom
fix/develop-validation-cleanup

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Rebased the validation cleanup branch onto current origin/develop and fixed the post-rebase typecheck/lint/audit fallout.
  • Keeps the runtime/UI validation fixes in this branch: renderer proxy API base normalization, dispatch route typing, Capacitor attachment stubs for web builds, shared UI event exports, website-blocker platform state, TEE import cleanup, and related formatter/lockfile sync.
  • Adds final verifier hardening: lifeops-bench now uses tsgo for typecheck, and the dist-path consumer audit skips local .claude worktree state.

Validation

  • git fetch origin && git rebase origin/develop onto f69e5cba71
  • bun install
  • bun run verify PASS (/tmp/eliza-root-verify-after-final-rebase-10.log)
  • bun run --cwd packages/app audit:app PASS earlier in this run: 373 passed; broken=0, needs-work=0, needs-eyeball=25, good=347
  • Focused follow-up checks while resolving verify fallout:
    • bun run --cwd packages/ui typecheck
    • bun run --cwd packages/ui lint
    • bun run --cwd packages/lifeops-bench typecheck
    • bun run audit:build-model
    • bun run typecheck:dist

Evidence Notes

  • Real-LLM trajectories: N/A - this branch is validation/build/type/runtime wiring cleanup, not a prompt/model behavior change.
  • Before/after screenshots and video: N/A for the final cleanup commit; app audit screenshots/manual review were run because the branch includes app/UI-touching changes.
  • Backend/frontend logs: N/A - no live server flow was changed or exercised in this final cleanup step.

Related: #12091

Shaw added 26 commits July 4, 2026 00:34
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 405a2b62-6fdf-440c-b805-24e134c322fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/develop-validation-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Closing this draft as superseded/stale. The verify-baseline pieces have already landed through #12919 plus the smaller #12259 follow-ups (#12917/#12923), and this branch is now conflicting with current develop. Any remaining validation cleanup should be split into fresh current-tip PRs with focused scope.

@lalalune lalalune closed this Jul 4, 2026
@lalalune lalalune reopened this Jul 4, 2026
@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Closing this stale draft. The actionable validation cleanup from this branch was split into smaller PRs and merged (including the script normalization and validation follow-ups), while this draft is now conflicting and no longer the review vehicle.

@lalalune lalalune closed this Jul 4, 2026
@lalalune
lalalune deleted the fix/develop-validation-cleanup branch July 4, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant