Skip to content

fix(#12259): remove lint build deps - #12923

Merged
lalalune merged 1 commit into
developfrom
fix/12259-lint-no-build-deps
Jul 4, 2026
Merged

fix(#12259): remove lint build deps#12923
lalalune merged 1 commit into
developfrom
fix/12259-lint-no-build-deps

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • remove generic build dependsOn from the Turbo lint task
  • remove generic build dependsOn from the Turbo lint:check task
  • leave typecheck build prerequisites unchanged

Evidence

  • .github/issue-evidence/12259-lint-no-build-deps.md

Verification

node -e "const fs=require('fs'); const t=JSON.parse(fs.readFileSync('turbo.json','utf8')).tasks; if ('dependsOn' in t.lint || 'dependsOn' in t['lint:check']) process.exit(1); if (!Array.isArray(t.typecheck.dependsOn)) process.exit(1);"
node -e "JSON.parse(require('fs').readFileSync('turbo.json','utf8'));"
git diff --check origin/develop..HEAD

Turbo dry-run evidence:

rm -f node_modules
ln -s /Users/shawwalters/eliza/node_modules node_modules
node packages/scripts/run-turbo.mjs run lint:check --dry=json --filter=./packages/core > /tmp/eliza-lint-dry.json
rm -f node_modules
node -e "const fs=require('fs'); const p=JSON.parse(fs.readFileSync('/tmp/eliza-lint-dry.json','utf8')); const tasks=p.tasks.map(t=>({taskId:t.taskId,dependencies:t.dependencies,dependsOn:t.resolvedTaskDefinition?.dependsOn})); console.log(JSON.stringify(tasks,null,2)); if (tasks.some(t => t.dependencies.length || t.dependsOn.length)) process.exit(1);"

Observed task summary:

[
  {
    "taskId": "@elizaos/core#lint:check",
    "dependencies": [],
    "dependsOn": []
  }
]

Screenshots/recordings: N/A, Turbo config only; no UI changed.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37ee155d-f1f1-44f1-a23b-3ce16fb7c3d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/12259-lint-no-build-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant