Skip to content

fix(#12259): mark persistent turbo tasks uncached - #12917

Merged
lalalune merged 1 commit into
developfrom
fix/12259-turbo-persistent-cache
Jul 4, 2026
Merged

lalalune merged 1 commit into
developfrom
fix/12259-turbo-persistent-cache

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

Evidence

  • .github/issue-evidence/12259-turbo-persistent-cache.md

Verification

node -e "const fs=require('fs'); const t=JSON.parse(fs.readFileSync('turbo.json','utf8')).tasks; if (t.dev.cache !== false || t.start.cache !== false) process.exit(1);"
node -e "JSON.parse(require('fs').readFileSync('turbo.json','utf8'));"
git diff --check origin/develop..HEAD

Screenshots/recordings: N/A, Turbo config only; no UI changed.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 916d287b-05f9-4ccc-9ad0-f84f78ad4147

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/12259-turbo-persistent-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune
lalalune merged commit 75223fb into develop Jul 4, 2026
17 of 36 checks passed
@lalalune
lalalune deleted the fix/12259-turbo-persistent-cache branch July 4, 2026 05:03
@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Local validation pass from an isolated checkout at /tmp/eliza-pr-12917.

Commands run:

node -e "const fs=require('fs'); const t=JSON.parse(fs.readFileSync('turbo.json','utf8')).tasks; if (t.dev.cache !== false || t.start.cache !== false) process.exit(1);"
node -e "JSON.parse(require('fs').readFileSync('turbo.json','utf8'));"
git diff --check github-develop..HEAD
git diff --stat github-develop...HEAD

Result: all passed. The merge-base diff is limited to turbo.json and .github/issue-evidence/12259-turbo-persistent-cache.md; start and dev are both persistent tasks and now explicitly set cache: false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant