fix: green verify baseline — browser redact export, logger arg order, prober contract, biome drift - #12919
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… prober contract, biome drift Repairs the accumulated red on develop so bun run verify passes again (modulo two pre-existing failures noted below): - @elizaos/core: export security/redact from the browser barrel — cloud-shared's logger (bundled into the app UI) imports isSensitiveKeyName/redactLogArgs from the root barrel (#12572 follow-up). - plugin-local-inference: fix two logger.warn(msg, {error}) calls to pino-style ({error}, msg) — introduced in #12546, broke typecheck of every package that type-includes the downloader source. - plugin-sql: carry the !agent.name narrowing across the withRetry closure in AgentStore.create (#12602 follow-up). - plugin-personal-assistant: adapt the website-blocking prober to the shared PermissionState contract (adds required platform field) instead of exposing plugin-blocker's narrower local shape. - plugin-tee: allowImportingTsExtensions (tsconfig is noEmit). - packages/ui: biome-ignore annotations for the two intentional registryVersion useMemo deps; type-collapse cast for the postcss/tailwind dual-major seam in the e2e fixture builder. - Repo-wide biome format normalization emitted by the self-fixing lint scripts (ui, agent, cloud-shared, cloud-ui and dependents). Still red on develop (pre-existing, untouched): @elizaos/app#typecheck (ui/navigation export resolution under tsgo), @elizaos/electrobun#typecheck. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lalalune
force-pushed
the
fix/develop-verify-baseline
branch
from
July 4, 2026 05:08
e50ca82 to
3d6c2a1
Compare
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This was referenced Jul 4, 2026
This was referenced Jul 4, 2026
NubsCarson
added a commit
that referenced
this pull request
Jul 4, 2026
…ges build (#13013) The #12848 promote brought packages/cloud/shared/src/lib/utils/logger.ts, which imports isSensitiveKeyName/redactLogArgs from @elizaos/core, but the matching core browser-barrel export (export * from "./security/redact" in packages/core/src/index.browser.ts) landed on develop in #12919 minutes AFTER the promote cut. Result: build:web fails on main with '"isSensitiveKeyName" is not exported by core dist/browser', so both prod Pages projects (eliza-cloud / eliza-app) cannot deploy from main — same skew class as #12985. One-file, additive-only cherry-pick of the index.browser.ts hunk from develop commit f317d1c (#12919). Verified locally at main tip: bun run build:core green, packages/app build:web green, verify-chunk-safety OK (392 chunks scanned).
6 tasks
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bun run verifyon a clean develop checkout fails in five places today, which blocks every branch from getting a green gate. This PR repairs the accumulated redness (all introduced by recent merges) in one hygiene pass.What
security/redactfrom the browser barrel —cloud-shared's logger (bundled into the app UI via rolldown) importsisSensitiveKeyName/redactLogArgsfrom the root barrel; the node/edge barrels export it, the browser one didn't (fix(#12229): route Feed A2A fetch through SSRF guard + converge log redaction #12572 follow-up). Fixes one of the@elizaos/appbundle build errors.logger.warn(msg, { error })→ pino-stylelogger.warn({ error }, msg)(fix: harden HF proxy downloads #12546 follow-up) — broke typecheck ofplugin-capacitor-bridge(type-includes the downloader source).!agent.namenarrowing across thewithRetryclosure inAgentStore.create(refactor(#12269): fail-fast DB adapters — throw ElizaError, drop fabricated defaults #12602 follow-up).PermissionStatecontract (requiredplatformfield) instead of plugin-blocker's narrower local shape. Also unblocks the arch-audit self-registration: Permission routes hardwire website-blocking to plugin-personal-assistant beside a stub prober (#12089 item 10) #12660 refactor.allowImportingTsExtensions(its tsconfig isnoEmit; source imports use.tssuffixes).biome-ignore+ rationale on the two intentionalregistryVersionuseMemo deps (they retriggerresolveWidgetsForSlotwhen the module-level registry mutates outside React); type-collapse cast for the postcss dual-major seam in the e2e fixture builder.Verification
bun run --cwd <pkg> typecheckgreen for: core, ui, agent, cloud-shared, cloud-ui, plugin-sql, plugin-tee, plugin-personal-assistant, plugin-capacitor-bridge, plugin-local-inference.node packages/scripts/run-turbo.mjs run lint --continue: zero failing packages (was: ui, agent, cloud-shared).bun run verify: green except two failures that are pre-existing on clean develop and untouched here:@elizaos/app#typecheck(ui/navigation export resolution under tsgo — exports exist in src and dist; resolution issue) and@elizaos/electrobun#typecheck(string | nullargs). Also pre-existing:@elizaos/app#buildcapacitor named-export resolution under rolldown (ios-attachment-smoke.ts, test(app): add iOS native attachment smoke for #10936 #12065).Evidence rows: format + type-level fixes, no runtime behavior change except the PA prober now reporting the contract-complete state shape; screenshots/video/trajectories N/A — no UI surface or model behavior change.
🤖 Generated with Claude Code