Skip to content

docs(#12863): add remote manifest residual headers - #12927

Merged
lalalune merged 1 commit into
developfrom
docs/comments-b02d-remote-manifest
Jul 4, 2026
Merged

docs(#12863): add remote manifest residual headers#12927
lalalune merged 1 commit into
developfrom
docs/comments-b02d-remote-manifest

Conversation

@lalalune

@lalalune lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Add purpose headers to residual plugin-remote-manifest test files and example workers.
  • Cover host shim, worker runtime, sub-agent, store/signature/permission tests, and install examples.
  • Keep the patch comment-only; code tokens are unchanged.

Fixes #12863

Validation

  • PASS bun run check:comment-only
  • PASS bun run --cwd packages/plugin-remote-manifest test (139 tests)
  • PASS bun run --cwd packages/plugin-remote-manifest typecheck
  • PASS bun run --cwd packages/plugin-remote-manifest lint
  • PASS git diff --check origin/develop...HEAD

Verification notes

  • bun run verify was attempted after fix: green verify baseline — browser redact export, logger arg order, prober contract, biome drift #12919 landed. In this local sparse checkout, packages/scripts is not materialized (git sparse-checkout list only includes packages/core, packages/scenario-runner, packages/shared, plugins/plugin-computeruse, plugins/plugin-vision), so multiple package builds failed to resolve packages/scripts/rm-path-recursive.mjs and packages/scripts/with-package-build-lock.mjs; verify then exited 139. This is a workspace checkout limitation, not a code-token change in this PR.

Evidence

  • UI/video/domain artifacts: N/A - comments-only change, zero functional diff machine-checked by scripts/assert-comment-only-diff.mjs.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea7b29fd-ce66-437f-960c-5d5bc15d4758

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/comments-b02d-remote-manifest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lalalune

lalalune commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Local validation pass from isolated checkout /tmp/eliza-pr-12927.

Commands run:

node scripts/assert-comment-only-diff.mjs github-develop
git diff --check github-develop...HEAD
bun run --cwd packages/plugin-remote-manifest test
bun run --cwd packages/plugin-remote-manifest typecheck
bun run --cwd packages/plugin-remote-manifest lint

Results: all passed. Comment-only proof covered 25 source files; package tests passed 139 tests / 1432 assertions; typecheck and Biome lint were clean.

@lalalune
lalalune merged commit b4e3a6a into develop Jul 4, 2026
42 of 72 checks passed
@lalalune
lalalune deleted the docs/comments-b02d-remote-manifest branch July 4, 2026 05:15
@claude

claude Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment cleanup B02-D: plugin remote manifest residuals (#12232 split)

2 participants