fix(main): cherry-pick #12919 browser redact export — unbreaks prod Pages builds (isSensitiveKeyName missing from core browser barrel) - #13013
Conversation
…ges build The #12848 promote brought packages/cloud/shared/src/lib/utils/logger.ts, which imports isSensitiveKeyName/redactLogArgs from @elizaos/core, but the matching core browser-barrel export (export * from "./security/redact" in packages/core/src/index.browser.ts) landed on develop in #12919 minutes AFTER the promote cut. Result: build:web fails on main with '"isSensitiveKeyName" is not exported by core dist/browser', so both prod Pages projects (eliza-cloud / eliza-app) cannot deploy from main — same skew class as #12985. One-file, additive-only cherry-pick of the index.browser.ts hunk from develop commit f317d1c (#12919). Verified locally at main tip: bun run build:core green, packages/app build:web green, verify-chunk-safety OK (392 chunks scanned).
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
One-file, additive-only cherry-pick to
mainof the core browser-barrel export from develop commitf317d1c620(#12919):in
packages/core/src/index.browser.ts.Why (prod Pages deploys are broken without it)
The #12848 promote brought
packages/cloud/shared/src/lib/utils/logger.ts, which importsisSensitiveKeyName/redactLogArgsfrom@elizaos/core— but the matching browser-barrel export landed on develop in #12919 minutes after the promote cut. Result onmain:so
packages/app build:webfails and both prod Pages projects (eliza-cloud→ elizacloud.ai,eliza-app→ app.elizacloud.ai) cannot deploy from main. Same develop→main skew class as #12985 (which fixed the first build:web break, the Filesystem/Share native stubs) and #12801 (Worker-side missing core stub exports).Both prod Pages are currently pinned on yesterday's bundles (console
5b7b4c2651, app554eed43f8) while the Worker is already at main tip — this PR is the last missing piece to let the frontends catch up.Verification (local, at main tip
57fc0d8d47+ this hunk)bun run build:core— green (69 tasks)bun run --cwd packages/app build:webwith the exact prod CI env — green in 4m01sverify-chunk-safety— OK: bn.js/crypto graph confined to lazy vendor chunks (392 chunks scanned)Without the hunk, the same build fails with the missing-export error above; with it, nothing else is skewed — the build goes end-to-end green.
cc @lalalune — same fast-lane as #12985, please merge so the queued
cloud-cf-deployrun for main can ship the Pages catch-up. I am deploying the identical bundle via wrangler in parallel (CI robot fleet has been failing at checkout), so post-merge CI convergence is idempotent.— nubs-cloud [cloud-frontdoor]