Skip to content

fix(main): cherry-pick #12919 browser redact export — unbreaks prod Pages builds (isSensitiveKeyName missing from core browser barrel) - #13013

Merged
NubsCarson merged 1 commit into
mainfrom
fix/main-browser-redact-export
Jul 4, 2026
Merged

fix(main): cherry-pick #12919 browser redact export — unbreaks prod Pages builds (isSensitiveKeyName missing from core browser barrel)#13013
NubsCarson merged 1 commit into
mainfrom
fix/main-browser-redact-export

Conversation

@NubsCarson

Copy link
Copy Markdown
Member

What

One-file, additive-only cherry-pick to main of the core browser-barrel export from develop commit f317d1c620 (#12919):

export * from "./security/redact";

in packages/core/src/index.browser.ts.

Why (prod Pages deploys are broken without it)

The #12848 promote brought packages/cloud/shared/src/lib/utils/logger.ts, which imports isSensitiveKeyName/redactLogArgs from @elizaos/core — but the matching browser-barrel export landed on develop in #12919 minutes after the promote cut. Result on main:

error during build:
../cloud/shared/src/lib/utils/logger.ts (16:6): "isSensitiveKeyName" is not exported by "../core/dist/browser/index.browser.js"

so packages/app build:web fails and both prod Pages projects (eliza-cloud → elizacloud.ai, eliza-app → app.elizacloud.ai) cannot deploy from main. Same develop→main skew class as #12985 (which fixed the first build:web break, the Filesystem/Share native stubs) and #12801 (Worker-side missing core stub exports).

Both prod Pages are currently pinned on yesterday's bundles (console 5b7b4c2651, app 554eed43f8) while the Worker is already at main tip — this PR is the last missing piece to let the frontends catch up.

Verification (local, at main tip 57fc0d8d47 + this hunk)

  • bun run build:core — green (69 tasks)
  • bun run --cwd packages/app build:web with the exact prod CI env — green in 4m01s
  • verify-chunk-safety — OK: bn.js/crypto graph confined to lazy vendor chunks (392 chunks scanned)

Without the hunk, the same build fails with the missing-export error above; with it, nothing else is skewed — the build goes end-to-end green.

cc @lalalune — same fast-lane as #12985, please merge so the queued cloud-cf-deploy run for main can ship the Pages catch-up. I am deploying the identical bundle via wrangler in parallel (CI robot fleet has been failing at checkout), so post-merge CI convergence is idempotent.

— nubs-cloud [cloud-frontdoor]

…ges build

The #12848 promote brought packages/cloud/shared/src/lib/utils/logger.ts,
which imports isSensitiveKeyName/redactLogArgs from @elizaos/core, but the
matching core browser-barrel export (export * from "./security/redact" in
packages/core/src/index.browser.ts) landed on develop in #12919 minutes
AFTER the promote cut. Result: build:web fails on main with
'"isSensitiveKeyName" is not exported by core dist/browser', so both
prod Pages projects (eliza-cloud / eliza-app) cannot deploy from main —
same skew class as #12985.

One-file, additive-only cherry-pick of the index.browser.ts hunk from
develop commit f317d1c (#12919). Verified locally at main tip:
bun run build:core green, packages/app build:web green,
verify-chunk-safety OK (392 chunks scanned).

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a41c795-be5d-484a-af3e-5e247eb4a920

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/main-browser-redact-export

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NubsCarson
NubsCarson merged commit 5319310 into main Jul 4, 2026
19 of 57 checks passed
@NubsCarson
NubsCarson deleted the fix/main-browser-redact-export branch July 4, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant