Upgrade EUI to v32.0.4 by thompsongl · Pull Request #96459 · elastic/kibana

thompsongl · 2021-04-07T17:08:52Z

Summary

v31.10.0 ⏩ v32.0.4

EuiPanel breaking changes were accounted for in a previous PR

Refactored internal structure and class names in EuiCard
Refactored internal structure of EuiButtonGroup
Tightened prop types of EuiAvatar
Updated styles for EuiPagination

`32.0.4`

Bug fixes

Removed the restriction on selectable EuiCard with layout="horizontal" (#4692)

`32.0.3`

Bug fixes

Exported EuiAvatarProps (#4690)
Fixed type overrides in EuiCard (#4690)

`32.0.2`

Bug fixes

Fixed htmlIdGenerator import path in button_group_button.tsx (#4682)
Fixed EuiColorStops popover failing to close (#4687)

`32.0.1`

Bug fixes

Fixed block style of EuiPanel when rendered as a <button> (#4681)

`32.0.0`

Added stepNumber prop and stepped as stopType option to EuiColorStops (#4613)
Expanded display prop of EuiCard to inherit color values from EuiPanel (#4649)
Added element prop to EuiPanel for forcing to div or button (#4649)
Increased padding on EuiCheckableCard with refactor to use EuiSplitPanel (#4649)
Added valueInputProps prop to EuiColorStops (#4669)
Added position, usePortal, top, right, bottom, and left props to EuiBottomBar (#4662)
Added bottomBar and bottomBarProps to EuiPageTemplate when template = 'default' (#4662)
Added role="main" to EuiPageContent by default (#4662)
Added bottomBorder prop to EuiPageHeader (#4662)

Bug fixes

Fixed id attribute to be unique across EuiButtonGroupButton elements (#4657)
Fixed responsive sizing of EuiModal (#4670)
Fixed disabled interactions of EuiHeaderSectionItemButton (#4670)
Hid of text on small screens for compressed EuiPagination(#4661)

Breaking changes

Removed betaBadgeLabel, betaBadgeTooltipContent, and betaBadgeTitle props from EuiPanel (#4649)
Changed EuiBottomBar positioning styles from being applied at the CSS layer to the style property (#4662)

`31.12.0`

Added indexRuntime glyph in EuiIcon (#4650)
Added iconType, iconColor, and iconSize props to EuiAvatar (#4620)
Added 'plain' and null as color options of EuiAvatar (#4620)

`31.11.0`

Added EuiNotificationEvent component (#4513)
Added euiAnimation() method on the EuiHeaderSectionItemButton ref (#4513)
Made description prop of EuiCard optional (#4546)

thompsongl · 2021-04-07T20:19:50Z

Error: EuiCard: layout = horizontal' cannot be used in conjunction with 'image', 'footer', 'textAlign', or 'selectable'.

From select_rule_type
@cchaos was this one of the necessary EuiCard changes that you were tracking?

Edit: Changing the rule in EUI to allow the configuration in question

thompsongl · 2021-04-08T19:28:39Z

test/functional/apps/discover/_data_grid_doc_table.ts

      // with the default range the number of hits is ~14000
      const rows = await dataGrid.getDocTableRows();
-      expect(rows.length).to.be(12);
+      expect(rows.length).to.be(11);


Increased size of EuiPagination slightly reduces the visible area, causing 1 fewer virtualized item.

elasticmachine · 2021-04-08T19:29:24Z

Pinging @elastic/eui-design (EUI)

elasticmachine · 2021-04-09T15:10:00Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2021-04-09T15:10:00Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2021-04-09T15:10:00Z

Pinging @elastic/uptime (Team:uptime)

cnasikas

Security solution changes LTGM

...nitor/status_details/availability_reporting/__snapshots__/location_status_tags.test.tsx.snap

sebelga

ES UI changes LGTM 👍

shahzad31

Uptime changes LGTM !!

smith

APM changes look good

nchaulet

Fleet changes 👍

kibanamachine · 2021-04-13T15:42:46Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	942.3KB	942.6KB	+352.0B
`security`	713.4KB	713.6KB	+196.0B
`securitySolution`	7.3MB	7.3MB	+63.0B
`spaces`	287.1KB	287.2KB	+100.0B
`triggersActionsUi`	1.5MB	1.5MB	+1.6KB
total			+2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	377.0KB	377.4KB	+440.0B
`data`	788.2KB	788.7KB	+584.0B
`kbnUiSharedDeps-css`	501.5KB	501.4KB	-163.0B
`kbnUiSharedDeps-elastic`	3.3MB	3.3MB	+16.3KB
`kbnUiSharedDeps-js`	6.7MB	6.7MB	+44.0B
`searchprofiler`	40.2KB	40.4KB	+224.0B
`visTypeTimeseries`	109.7KB	110.2KB	+472.0B
total			+17.9KB

History

💚 Build #118730 succeeded 3fb8dbf
💚 Build #118328 succeeded 102f809
💔 Build #118244 failed 51f7c03
💔 Build #118068 failed 59f3dd4
💔 Build #117951 failed 5a658fd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cqliu1

Snapshot changes for Canvas LGTM 👍

* eui to 31.12.0 * type updates * snapshot updates * snapshot updates * euiavatarprops * eui to 32.0.3 * euicard updates * update test

thompsongl added 7 commits April 6, 2021 16:45

eui to 31.12.0

e40b1b5

type updates

c40c7b6

snapshot updates

4cc4a70

snapshot updates

c51a382

euiavatarprops

4e610e3

Merge branch 'master' into eui/32.0

19b85be

eui to 32.0.3

5a658fd

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.13.0 labels Apr 7, 2021

thompsongl added 2 commits April 7, 2021 17:14

Merge branch 'master' into eui/32.0

dcc3473

euicard updates

59f3dd4

thompsongl changed the title ~~Upgrade EUI to v32.0.3~~ Upgrade EUI to v32.0.4 Apr 7, 2021

Merge branch 'master' into eui/32.0

51f7c03

dej611 mentioned this pull request Apr 8, 2021

[Lens] Adds dynamic table cell coloring #95217

Merged

3 tasks

update test

102f809

thompsongl commented Apr 8, 2021

View reviewed changes

thompsongl marked this pull request as ready for review April 8, 2021 19:29

thompsongl requested a review from a team April 8, 2021 19:29

thompsongl requested review from a team as code owners April 8, 2021 19:29

mattkime approved these changes Apr 9, 2021

View reviewed changes

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 9, 2021

lukeelmers approved these changes Apr 9, 2021

View reviewed changes

cnasikas approved these changes Apr 12, 2021

View reviewed changes

shahzad31 reviewed Apr 12, 2021

View reviewed changes

...nitor/status_details/availability_reporting/__snapshots__/location_status_tags.test.tsx.snap Show resolved Hide resolved

sebelga approved these changes Apr 12, 2021

View reviewed changes

shahzad31 approved these changes Apr 12, 2021

View reviewed changes

Merge branch 'master' into eui/32.0

3fb8dbf

smith approved these changes Apr 12, 2021

View reviewed changes

Merge branch 'master' into eui/32.0

1994016

nchaulet approved these changes Apr 13, 2021

View reviewed changes

legrego approved these changes Apr 13, 2021

View reviewed changes

cqliu1 approved these changes Apr 14, 2021

View reviewed changes

thompsongl merged commit d679035 into elastic:master Apr 14, 2021

thompsongl mentioned this pull request Apr 14, 2021

[7.x] Upgrade EUI to v32.0.4 (#96459) #97147

Merged

thompsongl added a commit to thompsongl/kibana that referenced this pull request Apr 14, 2021

Upgrade EUI to v32.0.4 (elastic#96459)

65a4411

* eui to 31.12.0 * type updates * snapshot updates * snapshot updates * euiavatarprops * eui to 32.0.3 * euicard updates * update test

thompsongl added a commit that referenced this pull request Apr 14, 2021

Upgrade EUI to v32.0.4 (#96459) (#97147)

9971605

* eui to 31.12.0 * type updates * snapshot updates * snapshot updates * euiavatarprops * eui to 32.0.3 * euicard updates * update test

Conversation

thompsongl commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

thompsongl commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 8, 2021

Uh oh!

elasticmachine commented Apr 9, 2021

Uh oh!

elasticmachine commented Apr 9, 2021

Uh oh!

elasticmachine commented Apr 9, 2021

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebelga left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 13, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

cqliu1 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

thompsongl commented Apr 7, 2021 •

edited

Loading

thompsongl commented Apr 7, 2021 •

edited

Loading