[EuiCard] Allow selectable with layout="horizontal"#4692
Merged
thompsongl merged 3 commits intoelastic:masterfrom Apr 7, 2021
Merged
[EuiCard] Allow selectable with layout="horizontal"#4692thompsongl merged 3 commits intoelastic:masterfrom
selectable with layout="horizontal"#4692thompsongl merged 3 commits intoelastic:masterfrom
Conversation
| }); | ||
| }); | ||
|
|
||
| test('horizontal selectable', () => { |
chandlerprall
approved these changes
Apr 7, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Focused on TS changes
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4692/ |
cchaos
approved these changes
Apr 7, 2021
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
🙏 Thanks so much @thompsongl !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows for
selectableEuiCard withlayout="horizontal"Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Added documentation- [ ] Checked for accessibility including keyboard-only and screenreader modes