[EuiPanel] Fix selector for button element styling#4681
Merged
cchaos merged 3 commits intoelastic:masterfrom Apr 1, 2021
Merged
[EuiPanel] Fix selector for button element styling#4681cchaos merged 3 commits intoelastic:masterfrom
button element styling#4681cchaos merged 3 commits intoelastic:masterfrom
Conversation
added 2 commits
April 1, 2021 14:26
chandlerprall
approved these changes
Apr 1, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Change LGTM and decision to use :enabled makes sense. Tested locally across the 4 themes + color modes combos.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4681/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4662, I introduced a bug trying to scope specific
<button>styles in theeuiPanel()mixin. I mistakenly thought, but didn't check that my Sass nested selector would work. It didn't.This PR fixes the block display of
EuiPanel.onClickby using the:enabledselector instead.Before
After
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes