[Docs] Updates to the layout section (part 2)#4670
Merged
cchaos merged 10 commits intoelastic:masterfrom Mar 31, 2021
Merged
Conversation
added 6 commits
March 27, 2021 17:54
(didn’t adjust all the examples, but probably will when I tackle the EuiAppLayout component)
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4670/ |
chandlerprall
approved these changes
Mar 29, 2021
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Documentation changes are 💯
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4670/ |
Contributor
Author
|
Hmm, looks like this PR is also failing on the same tests as #4662 (comment) |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4670/ |
Contributor
Author
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4670/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4670/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles the following component pages:
There were also 2 fixes to actual components too:
Fixed sizing of EuiModal if the browser window was narrower than the
widthandmaxWidth. Basically it was forcing a max width of100vw, so you could get it to a point where it would stretch beyond the window width. So I used themin()css function providing that if100vwwas smaller than the max-width, to use that value instead.The new EuiNotificationEvent has a slight conflict that wasn't resolved properly when EuiHeaderSectionItemButton was updated to extend EuiButtonEmpty. It was forcing a
:hoverand:focusstate that wasn't accounting fordisabledstates. So I removed these specific styles to align with EuiButtonEmpty.Checklist
[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes