[Fleet] UI changes on hosted policy detail view by jfsiii · Pull Request #96337 · elastic/kibana

jfsiii · 2021-04-06T17:16:34Z

Summary

Fixes several items from https://github.com/elastic/observability-design/issues/32

Agent policy detail page
- Integrations tab: 1a) Show a lock icon with hover tooltip next to host policy name
- Integrations tab: 7a) hide the "Add integration" button
- Integrations tab: 7b) hide the "delete integration" action which appears in the [...] actions menu
- Settings tab: 5a) Do not show the “Delete policy” section for Hosted agent policies
- Settings tab: 5b) Disable the "name" and "description" inputs
Agents detail page
- 2b) remove the "actions" button in the page header (top right)

Screenshots

Agent policy detail page - Integrations tab

1a) Show a lock icon with hover tooltip next to host policy name
7a) hide the "Add integration" button
7b) hide the "delete integration" action which appears in the [...] actions menu

Non-hosted policy

Hosted policy

Agent policy detail page - Settings tab

5a) Do not show the “Delete policy” section for Hosted agent policies
5b) Disable the "name" and "description" inputs

non-hosted policy: items available

Hosted policy: items hidden / disabled

Agents detail page: 2b) remove the "actions" button in the page header (top right)

shown on non-hosted policy

hidden on hosted policy

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

…na into hosted-policy-detail-changes

jfsiii · 2021-04-08T00:58:09Z

@elasticmachine merge upstream

…na into hosted-policy-detail-changes

elasticmachine · 2021-04-08T17:42:01Z

Pinging @elastic/fleet (Team:Fleet)

jfsiii · 2021-04-08T23:30:28Z

@elasticmachine merge upstream

jfsiii · 2021-04-09T00:14:14Z

x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.tsx


-    const agentPolicy = agentPolicies.find((p) => p.id === agent.policy_id);
-    const isManaged = agent.policy_id && agentPolicy?.is_managed === true;
+    const agentPolicy = agentPoliciesIndexedById[agent.policy_id];


@nchaulet This is the follow up mentioned in #96160 (comment)

jfsiii · 2021-04-09T00:45:00Z

@elasticmachine merge upstream

kibanamachine · 2021-04-09T00:45:12Z

expected head sha didn’t match current head ref.

jfsiii · 2021-04-11T20:09:35Z

@elasticmachine merge upstream

kibanamachine · 2021-04-11T22:09:37Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	710.0KB	711.2KB	+1.2KB

History

💚 Build #118482 succeeded 1c7bfcb
💔 Build #118472 failed b142cb9
💚 Build #118084 succeeded 21d3d11
💔 Build #117958 failed b52c468
💚 Build #117623 succeeded 18fca79

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

nchaulet

Looks good to me 👍

## Summary Fixes several items from elastic/observability-design#32 - Agent policy detail page - [x] Integrations tab: 1a) Show a lock icon with hover tooltip next to host policy name - [x] Integrations tab: 7a) hide the "Add integration" button - [x] Integrations tab: 7b) hide the "delete integration" action which appears in the [...] actions menu - [x] Settings tab: 5a) Do not show the “Delete policy” section for Hosted agent policies - [x] Settings tab: 5b) Disable the "name" and "description" inputs - Agents detail page - [x] 2b) remove the "actions" button in the page header (top right) ## Screenshots <details><summary>Agent policy detail page - Integrations tab</summary> <ul> <li>1a) Show a lock icon with hover tooltip next to host policy name</li> <li>7a) hide the "Add integration" button</li> <li>7b) hide the "delete integration" action which appears in the [...] actions menu</li> </ul> <h3>Non-hosted policy</h3> <img width="1186" alt="Screen Shot 2021-04-08 at 1 30 24 PM" src="https://user-images.githubusercontent.com/57655/114071393-0eade000-986f-11eb-847f-0c64c7d2aa5e.png"> <h3>Hosted policy</h3> <img width="1184" alt="Screen Shot 2021-04-08 at 1 29 26 PM" src="https://user-images.githubusercontent.com/57655/114071389-0eade000-986f-11eb-9501-332509b0a85d.png"> </details> <details><summary>Agent policy detail page - Settings tab</summary> <ul> <li>5a) Do not show the “Delete policy” section for Hosted agent policies</li> <li>5b) Disable the "name" and "description" inputs</li> </ul> <h3>non-hosted policy: items available</h3> <img width="1209" alt="Screen Shot 2021-04-07 at 1 24 39 PM" src="https://user-images.githubusercontent.com/57655/114069262-cdb4cc00-986c-11eb-84c8-926c98a75d47.png"> <h3>Hosted policy: items hidden / disabled</h3> <img width="1228" alt="Screen Shot 2021-04-07 at 1 24 23 PM" src="https://user-images.githubusercontent.com/57655/114069259-cdb4cc00-986c-11eb-82fc-39509c6ef9fe.png"> </details> <details><summary>Agents detail page: 2b) remove the "actions" button in the page header (top right)</summary> <h4>shown on non-hosted policy</h4> <img width="1408" alt="Screen Shot 2021-04-08 at 9 55 06 AM" src="https://user-images.githubusercontent.com/57655/114068747-38193c80-986c-11eb-9fb6-b8f9eb77a1d6.png"> <h4>hidden on hosted policy</h4> <img width="1345" alt="Screen Shot 2021-04-08 at 9 55 31 AM" src="https://user-images.githubusercontent.com/57655/114068748-38b1d300-986c-11eb-9eee-ee15f8acd718.png"> </details> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-04-12T13:46:05Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...

## Summary Fixes several items from elastic/observability-design#32 - Agent policy detail page - [x] Integrations tab: 1a) Show a lock icon with hover tooltip next to host policy name - [x] Integrations tab: 7a) hide the "Add integration" button - [x] Integrations tab: 7b) hide the "delete integration" action which appears in the [...] actions menu - [x] Settings tab: 5a) Do not show the “Delete policy” section for Hosted agent policies - [x] Settings tab: 5b) Disable the "name" and "description" inputs - Agents detail page - [x] 2b) remove the "actions" button in the page header (top right) ## Screenshots <details><summary>Agent policy detail page - Integrations tab</summary> <ul> <li>1a) Show a lock icon with hover tooltip next to host policy name</li> <li>7a) hide the "Add integration" button</li> <li>7b) hide the "delete integration" action which appears in the [...] actions menu</li> </ul> <h3>Non-hosted policy</h3> <img width="1186" alt="Screen Shot 2021-04-08 at 1 30 24 PM" src="https://user-images.githubusercontent.com/57655/114071393-0eade000-986f-11eb-847f-0c64c7d2aa5e.png"> <h3>Hosted policy</h3> <img width="1184" alt="Screen Shot 2021-04-08 at 1 29 26 PM" src="https://user-images.githubusercontent.com/57655/114071389-0eade000-986f-11eb-9501-332509b0a85d.png"> </details> <details><summary>Agent policy detail page - Settings tab</summary> <ul> <li>5a) Do not show the “Delete policy” section for Hosted agent policies</li> <li>5b) Disable the "name" and "description" inputs</li> </ul> <h3>non-hosted policy: items available</h3> <img width="1209" alt="Screen Shot 2021-04-07 at 1 24 39 PM" src="https://user-images.githubusercontent.com/57655/114069262-cdb4cc00-986c-11eb-84c8-926c98a75d47.png"> <h3>Hosted policy: items hidden / disabled</h3> <img width="1228" alt="Screen Shot 2021-04-07 at 1 24 23 PM" src="https://user-images.githubusercontent.com/57655/114069259-cdb4cc00-986c-11eb-82fc-39509c6ef9fe.png"> </details> <details><summary>Agents detail page: 2b) remove the "actions" button in the page header (top right)</summary> <h4>shown on non-hosted policy</h4> <img width="1408" alt="Screen Shot 2021-04-08 at 9 55 06 AM" src="https://user-images.githubusercontent.com/57655/114068747-38193c80-986c-11eb-9fb6-b8f9eb77a1d6.png"> <h4>hidden on hosted policy</h4> <img width="1345" alt="Screen Shot 2021-04-08 at 9 55 31 AM" src="https://user-images.githubusercontent.com/57655/114068748-38b1d300-986c-11eb-9eee-ee15f8acd718.png"> </details> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Schulz <john.schulz@elastic.co>

John Schulz added 3 commits April 6, 2021 13:06

Agent policy detail: Add lock icon w/tootip if hosted

405888f

No 'delete integration' menu item for hosted policies

08d399a

Lookup the policy directly versus searching for it

18fca79

jfsiii self-assigned this Apr 6, 2021

John Schulz added 4 commits April 7, 2021 12:41

Better (if not perfect) name & icon lockup

bad2618

Hide 'Add integration' on detail page of hosted policies

66fd534

Disable or hide restricted parts of settings tab for hosted policy

a5cafed

Merge branch 'hosted-policy-detail-changes' of github.com:jfsiii/kiba…

b52c468

…na into hosted-policy-detail-changes

jfsiii mentioned this pull request Apr 7, 2021

[Fleet] Disable Delete Policy button for Managed Policies #96492

Closed

kibanamachine and others added 3 commits April 7, 2021 20:58

Merge branch 'master' into hosted-policy-detail-changes

21d3d11

Hide actions button on agent details page for hosted agents

ba68056

Merge branch 'hosted-policy-detail-changes' of github.com:jfsiii/kiba…

eba4726

…na into hosted-policy-detail-changes

jfsiii added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 8, 2021

jfsiii marked this pull request as ready for review April 8, 2021 17:41

jfsiii requested a review from a team as a code owner April 8, 2021 17:41

jfsiii requested a review from hbharding April 8, 2021 17:42

jfsiii mentioned this pull request Apr 8, 2021

[Fleet] UI changes related to hosted agent policies #91906

Closed

23 tasks

jfsiii changed the title ~~Hosted policy detail changes~~ [Fleet] UI changes on hosted policy detail view Apr 8, 2021

Merge branch 'master' into hosted-policy-detail-changes

b142cb9

jfsiii commented Apr 9, 2021

View reviewed changes

Merge branch 'master' into hosted-policy-detail-changes

1c7bfcb

Merge branch 'master' into hosted-policy-detail-changes

1cb744b

nchaulet approved these changes Apr 12, 2021

View reviewed changes

jfsiii added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 12, 2021

jfsiii merged commit c401211 into elastic:master Apr 12, 2021

kibanamachine mentioned this pull request Apr 12, 2021

[7.x] [Fleet] UI changes on hosted policy detail view (#96337) #96785

Merged

jfsiii mentioned this pull request Apr 30, 2021

[Fleet] Remove "delete policy" button for policies which cannot be deleted #95226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] UI changes on hosted policy detail view#96337

[Fleet] UI changes on hosted policy detail view#96337
jfsiii merged 13 commits intoelastic:masterfrom
jfsiii:hosted-policy-detail-changes

jfsiii commented Apr 6, 2021 •

edited

Loading

Uh oh!

jfsiii commented Apr 8, 2021

Uh oh!

elasticmachine commented Apr 8, 2021

Uh oh!

jfsiii commented Apr 8, 2021

Uh oh!

jfsiii Apr 9, 2021

Uh oh!

jfsiii commented Apr 9, 2021

Uh oh!

kibanamachine commented Apr 9, 2021

Uh oh!

jfsiii commented Apr 11, 2021

Uh oh!

kibanamachine commented Apr 11, 2021

Uh oh!

nchaulet left a comment

Uh oh!

kibanamachine commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jfsiii commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Non-hosted policy

Hosted policy

non-hosted policy: items available

Hosted policy: items hidden / disabled

shown on non-hosted policy

hidden on hosted policy

Checklist

Uh oh!

jfsiii commented Apr 8, 2021

Uh oh!

elasticmachine commented Apr 8, 2021

Uh oh!

jfsiii commented Apr 8, 2021

Uh oh!

jfsiii Apr 9, 2021

Choose a reason for hiding this comment

Uh oh!

jfsiii commented Apr 9, 2021

Uh oh!

kibanamachine commented Apr 9, 2021

Uh oh!

jfsiii commented Apr 11, 2021

Uh oh!

kibanamachine commented Apr 11, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 12, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jfsiii commented Apr 6, 2021 •

edited

Loading