Skip to content

[7.x] [Fleet] UI changes on hosted policy detail view (#96337)#96785

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-96337
Apr 12, 2021
Merged

[7.x] [Fleet] UI changes on hosted policy detail view (#96337)#96785
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-96337

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

## Summary

Fixes several items from elastic/observability-design#32

- Agent policy detail page
  - [x] Integrations tab: 1a) Show a lock icon with hover tooltip next to host policy name
  - [x] Integrations tab: 7a) hide the "Add integration" button
  - [x] Integrations tab: 7b) hide the "delete integration" action which appears in the [...] actions menu
  - [x] Settings tab: 5a) Do not show the “Delete policy” section for Hosted agent policies
  - [x] Settings tab: 5b) Disable the "name" and "description" inputs
 - Agents detail page
   - [x] 2b) remove the "actions" button in the page header (top right)

## Screenshots

<details><summary>Agent policy detail page - Integrations tab</summary>
<ul>
<li>1a) Show a lock icon with hover tooltip next to host policy name</li>
<li>7a) hide the "Add integration" button</li>
<li>7b) hide the "delete integration" action which appears in the [...] actions menu</li>
</ul>

<h3>Non-hosted policy</h3>
<img width="1186" alt="Screen Shot 2021-04-08 at 1 30 24 PM" src="https://user-images.githubusercontent.com/57655/114071393-0eade000-986f-11eb-847f-0c64c7d2aa5e.png">

<h3>Hosted policy</h3>
<img width="1184" alt="Screen Shot 2021-04-08 at 1 29 26 PM" src="https://user-images.githubusercontent.com/57655/114071389-0eade000-986f-11eb-9501-332509b0a85d.png">

</details>

<details><summary>Agent policy detail page - Settings tab</summary>

<ul>
<li>5a) Do not show the “Delete policy” section for Hosted agent policies</li>
<li>5b) Disable the "name" and "description" inputs</li>
</ul>

<h3>non-hosted policy: items available</h3>
<img width="1209" alt="Screen Shot 2021-04-07 at 1 24 39 PM" src="https://user-images.githubusercontent.com/57655/114069262-cdb4cc00-986c-11eb-84c8-926c98a75d47.png">

<h3>Hosted policy: items hidden / disabled</h3>
<img width="1228" alt="Screen Shot 2021-04-07 at 1 24 23 PM" src="https://user-images.githubusercontent.com/57655/114069259-cdb4cc00-986c-11eb-82fc-39509c6ef9fe.png">

</details>

<details><summary>Agents detail page: 2b) remove the "actions" button in the page header (top right)</summary>

<h4>shown on non-hosted policy</h4>
<img width="1408" alt="Screen Shot 2021-04-08 at 9 55 06 AM" src="https://user-images.githubusercontent.com/57655/114068747-38193c80-986c-11eb-9fb6-b8f9eb77a1d6.png">

<h4>hidden on hosted policy</h4>
<img width="1345" alt="Screen Shot 2021-04-08 at 9 55 31 AM" src="https://user-images.githubusercontent.com/57655/114068748-38b1d300-986c-11eb-9eee-ee15f8acd718.png">

</details>

### Checklist
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)


Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Apr 12, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) April 12, 2021 13:46
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 710.0KB 711.2KB +1.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

@kibanamachine kibanamachine merged commit ba78498 into elastic:7.x Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants