[Partial Results] Move inspector adapter integration into search source by lizozom · Pull Request #96241 · elastic/kibana

lizozom · 2021-04-05T18:50:52Z

Summary

Partially resolves #83652

Release Note

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…tor-integration-in-search-source

elasticmachine · 2021-04-06T10:33:22Z

Pinging @elastic/kibana-app-services (Team:AppServices)

ppisljar · 2021-04-07T07:22:33Z

src/plugins/data/common/search/expressions/esaggs/request_handler.ts

+  const response$ = await requestSearchSource.fetch$({
+    abortSignal,
+    sessionId: searchSessionId,
+    requestResponder,


i think it makes sense here to pass inspectorAdapters.requests in, as we'll need that to construct the other bucket inside searchsource as well. i'm fine with leaving it as is for now however as we plan to move the other bucket code inside searchsource in a followup pr.

I agree and I intend to make that change in the other bucket PR

ppisljar

code LGTM

majagrubic

search-embeddable changes LGTM 👍

majagrubic · 2021-04-08T07:04:22Z

src/plugins/data/common/search/search_source/search_source.ts

-  async getSearchRequestBody() {
-    const searchRequest = await this.flatten();
-    return searchRequest.body;
+  getSearchRequestBody() {


Why is this not async any more?

flatten was never async, this is just ceanup

ppisljar · 2021-04-08T14:03:27Z

@elasticmachine merge upstream

kibanamachine · 2021-04-08T14:03:29Z

merge conflict between base and head

…tor-integration-in-search-source

lizozom · 2021-04-08T19:26:19Z

@elasticmachine merge upstream

kibanamachine · 2021-04-08T21:28:53Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`data`	561	562	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	393.9KB	393.5KB	-410.0B
`maps`	2.6MB	2.6MB	-444.0B
total			-854.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	787.2KB	788.0KB	+777.0B
`discover`	74.7KB	74.4KB	-289.0B
total			+488.0B

History

💚 Build #117467 succeeded f927075
💔 Build #117332 failed 173b1b9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

…ce (elastic#96241) * Move inspector adapter integration into search source * docs and ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-04-09T15:31:57Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…ce (#96241) (#96701) * Move inspector adapter integration into search source * docs and ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza Katz <lizka.k@gmail.com>

…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...

Move inspector adapter integration into search source

173b1b9

lizozom self-assigned this Apr 5, 2021

lizozom added Team:AppServices v7.13.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement labels Apr 5, 2021

lizozom requested a review from ppisljar April 5, 2021 18:52

lizozom mentioned this pull request Apr 5, 2021

Partial Results for Expressions #84051

Closed

14 tasks

Liza K added 2 commits April 6, 2021 11:29

docs and ts

d3c9dbb

Merge branch 'master' of github.com:elastic/kibana into search/inspec…

f927075

…tor-integration-in-search-source

lizozom marked this pull request as ready for review April 6, 2021 10:33

lizozom requested a review from a team April 6, 2021 10:33

lizozom requested a review from a team as a code owner April 6, 2021 10:33

Merge branch 'master' of github.com:elastic/kibana into search/inspec…

f44c320

…tor-integration-in-search-source

ppisljar reviewed Apr 7, 2021

View reviewed changes

ppisljar approved these changes Apr 7, 2021

View reviewed changes

lizozom added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Apr 7, 2021

lizozom changed the title ~~Move inspector adapter integration into search source~~ [Partial Results] Move inspector adapter integration into search source Apr 7, 2021

lizozom mentioned this pull request Apr 7, 2021

[Partial Results] Move other bucket into Search Source #96384

Merged

9 tasks

majagrubic approved these changes Apr 8, 2021

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into search/inspec…

4de3e7b

…tor-integration-in-search-source

Merge branch 'master' into search/inspector-integration-in-search-source

2996601

lizozom merged commit b099a0b into elastic:master Apr 9, 2021

kibanamachine mentioned this pull request Apr 9, 2021

[7.x] [Partial Results] Move inspector adapter integration into search source (#96241) #96701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Partial Results] Move inspector adapter integration into search source#96241

[Partial Results] Move inspector adapter integration into search source#96241
lizozom merged 6 commits intoelastic:masterfrom
lizozom:search/inspector-integration-in-search-source

lizozom commented Apr 5, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Apr 6, 2021

Uh oh!

ppisljar Apr 7, 2021

Uh oh!

lizozom Apr 7, 2021

Uh oh!

ppisljar left a comment

Uh oh!

majagrubic left a comment

Uh oh!

majagrubic Apr 8, 2021

Uh oh!

ppisljar Apr 8, 2021

Uh oh!

ppisljar commented Apr 8, 2021

Uh oh!

kibanamachine commented Apr 8, 2021

Uh oh!

lizozom commented Apr 8, 2021

Uh oh!

kibanamachine commented Apr 8, 2021

Uh oh!

kibanamachine commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lizozom commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release Note

Checklist

For maintainers

Uh oh!

elasticmachine commented Apr 6, 2021

Uh oh!

ppisljar Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

lizozom Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

majagrubic left a comment

Choose a reason for hiding this comment

Uh oh!

majagrubic Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

ppisljar Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

ppisljar commented Apr 8, 2021

Uh oh!

kibanamachine commented Apr 8, 2021

Uh oh!

lizozom commented Apr 8, 2021

Uh oh!

kibanamachine commented Apr 8, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Apr 9, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lizozom commented Apr 5, 2021 •

edited

Loading