[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert by nreese · Pull Request #96633 · elastic/kibana

nreese · 2021-04-08T18:53:34Z

This PR switches the implementation of IndexPatternSelect from using indexPatternService.find to instead using a combination of indexPatternService.getIdsWithTitle and indexPatternService.get. This was suggested by @mattkime to avoid using indexPatternService.find with a really large page size.

…empting to create a Tracking Containment alert

elasticmachine · 2021-04-08T18:54:08Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2021-04-08T18:55:59Z

@elasticmachine merge upstream

mattkime

index pattern changes look good to me

…ervice to add saved object to cache when index pattern is created

nreese · 2021-04-08T20:25:23Z

src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts

    });
    indexPattern.id = response.id;
    this.indexPatternCache.set(indexPattern.id, Promise.resolve(indexPattern));
+    this.savedObjectsCache.push(response);


@mattkime Mind taking a look at this change. I was running into a problem where uploading a file in maps, https://www.elastic.co/guide/en/kibana/7.x/import-geospatial-data.html, resulted in getIdsAndTitles not containing the new index pattern. Instead of forcing IndexPatternSelect to call getIdsAndTitles with a force refresh, lets just update the cache when an index pattern is added

thomasneirynck

thx. I tested in alerting and maps and works as expected.

Thanks for creating #96644 as follow-up. That's a really interesting approach; fixing the problem by punting on the issue altogether.

src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx

kindsun

One minor comment but functionally worked really well. Thanks for the quick fix!

code review
tested locally in chrome

kibanamachine · 2021-04-09T02:07:23Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`data`	177.1KB	177.2KB	+149.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	787.2KB	787.3KB	+62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…empting to create a Tracking Containment alert (elastic#96633) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…empting to create a Tracking Containment alert (elastic#96633) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md

…empting to create a Tracking Containment alert (#96633) (#96682) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md

…empting to create a Tracking Containment alert (#96633) (#96681) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...

[Maps] fix Kibana does not recognize a valid geo_shape index when att…

87072c8

…empting to create a Tracking Containment alert

nreese requested review from kindsun, mattkime and thomasneirynck April 8, 2021 18:53

nreese requested a review from a team as a code owner April 8, 2021 18:53

nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.1 v7.13.0 v8.0.0 labels Apr 8, 2021

Merge branch 'master' into issue_95418

f829c2d

mattkime approved these changes Apr 8, 2021

View reviewed changes

nreese added 3 commits April 8, 2021 13:25

tslint

50b8a00

Merge branch 'issue_95418' of github.com:nreese/kibana into issue_95418

8ab7ad3

instead of forcing refresh on getIdsAndTitles, update index pattern s…

a21b45e

…ervice to add saved object to cache when index pattern is created

nreese commented Apr 8, 2021

View reviewed changes

nreese added 3 commits April 8, 2021 14:28

simplify title check

d171fd3

revert unneeded changes

00af442

tslint

0ed8843

thomasneirynck approved these changes Apr 8, 2021

View reviewed changes

kindsun reviewed Apr 8, 2021

View reviewed changes

src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx Show resolved Hide resolved

kindsun approved these changes Apr 8, 2021

View reviewed changes

nreese added 2 commits April 8, 2021 16:28

api doc updates

f4535ad

fix functional test

3ea0e2f

nreese merged commit ec070d3 into elastic:master Apr 9, 2021

nreese mentioned this pull request Apr 9, 2021

[7.x] [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (#96633) #96681

Merged

nreese mentioned this pull request Apr 9, 2021

[7.12] [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (#96633) #96682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert#96633

[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert#96633
nreese merged 10 commits intoelastic:masterfrom
nreese:issue_95418

nreese commented Apr 8, 2021

Uh oh!

elasticmachine commented Apr 8, 2021

Uh oh!

nreese commented Apr 8, 2021

Uh oh!

mattkime left a comment

Uh oh!

nreese Apr 8, 2021 •

edited

Loading

Uh oh!

thomasneirynck left a comment

Uh oh!

Uh oh!

kindsun left a comment

Uh oh!

kibanamachine commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nreese commented Apr 8, 2021

Uh oh!

elasticmachine commented Apr 8, 2021

Uh oh!

nreese commented Apr 8, 2021

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

nreese Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kindsun left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 9, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nreese Apr 8, 2021 •

edited

Loading