Skip to content

[APM] Add log_level/sanitize_field_names config options to Python Agent#84810

Merged
basepi merged 2 commits intoelastic:masterfrom
basepi:remote_config
Dec 3, 2020
Merged

[APM] Add log_level/sanitize_field_names config options to Python Agent#84810
basepi merged 2 commits intoelastic:masterfrom
basepi:remote_config

Conversation

@basepi
Copy link
Copy Markdown
Contributor

@basepi basepi commented Dec 2, 2020 •
edited
Loading

Summary

Adds the existing log_level and sanitize_field_names configs to the python agent config options.

Closes elastic/apm-agent-python#969
Ref elastic/apm-agent-python#904

Checklist

Delete any items that are not applicable to this PR.

(None of the items were applicable to this change)

For maintainers

@basepi basepi added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0 labels Dec 2, 2020
@basepi basepi self-assigned this Dec 2, 2020
@basepi basepi requested a review from a team December 2, 2020 18:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2020

Pinging @elastic/apm-ui (Team:apm)

@basepi
Copy link
Copy Markdown
Contributor Author

basepi commented Dec 2, 2020

Note that this will conflict with #84678 and require a rebase.

sorenlouv
sorenlouv approved these changes Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding this 👍

@basepi basepi changed the title [APM] Add log_level config option to Python Agent [APM] Add log_level/sanitize_field_names config options to Python Agent Dec 3, 2020
@basepi basepi requested a review from sorenlouv December 3, 2020 19:01
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 3, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +18.0B

History

  • 💚 Build #91473 succeeded c96fd6a93e0d3117bddf4ec1868431522d280df9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@basepi basepi merged commit eb46f3a into elastic:master Dec 3, 2020
@sorenlouv
Copy link
Copy Markdown
Member

sorenlouv commented Dec 3, 2020 •
edited
Loading

@basepi You can backport this to 7.x by running node scripts/backport.js from the kibana root. LMK if you need some help or find the readme for setting up the backport tool here: https://github.com/sqren/backport

gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 4, 2020
@gmmorris
Merge branch 'master' into alerts/custom-recovery-action-group
8940592 
* master: (28 commits)
  [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891)
  Only attempt to rollover signals index if version < builtin version (elastic#84982)
  skip flaky suite (elastic#84978)
  skip lens rollup tests
  Add geo containment tracking alert type (elastic#84151)
  Changed rollup tests to use test user rather than elastic super user. (elastic#79567)
  skip 'should allow creation of lens xy chart' elastic#84957
  [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810)
  [Maps] geo line source (elastic#76572)
  [data.search] Move search method inside session service and add tests (elastic#84715)
  skip lens drag and drop test.  elastic#84941
  [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554)
  [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640)
  [Lens] Fix error when selecting the current field again (elastic#84817)
  [Metrics UI] Add metadata tab to node details flyout (elastic#84454)
  [CI] Enables APM collection (elastic#81731)
  [Workplace Search] Migrate Sources Schema tree (elastic#84847)
  Disable checking for conflicts when copying saved objects (elastic#83575)
  [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368)
  y18n 4.0.0 -> 4.0.1 (elastic#84905)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 7, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 7, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84810 or prevent reminders by adding the backport:skip label.

@sorenlouv sorenlouv mentioned this pull request Dec 8, 2020
Merged
sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request Dec 8, 2020
@basepi @sorenlouv
[APM] Add log_level/sanitize_field_names config options to Python Age…
0e1206a 
…nt (elastic#84810)

* [APM] Add log_level config option to Python Agent

* Add sanitize_field_names as well
sorenlouv added a commit that referenced this pull request Dec 8, 2020
@sorenlouv @basepi
[7.x] [APM] Add log_level/sanitize_field_names config options to Pyth…
a65989c 
…on Agent (#84810) (#85214)

* [APM] Add log_level config option to Python Agent

* Add sanitize_field_names as well

Co-authored-by: Colton Myers <colton.myers@gmail.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv Awaiting requested review from sorenlouv

Assignees

@basepi basepi

Labels

release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[META 321] Add log_level option to central Kibana configuration

4 participants

@basepi @elasticmachine @kibanamachine @sorenlouv