[Workplace Search] Migrate Sources Schema tree#84847
Merged
scottybollinger merged 15 commits intoelastic:masterfrom Dec 3, 2020
Merged
[Workplace Search] Migrate Sources Schema tree#84847scottybollinger merged 15 commits intoelastic:masterfrom
scottybollinger merged 15 commits intoelastic:masterfrom
Conversation
Only does linting changes and:
- lodash imports
- Replace unescaped apostrophes with '
- Fix ternary function call to if block:
if (isAdding) {
actions.onSchemaSetFormErrors(errors);
} else {
actions.onSchemaSetError({ flashMessages: { error: errors } });
}
- Adds getReindexJobRoute method to routes - Repalces legacy Rails routes helper with hard-coded paths
Added here: elastic#84822
Without this, the IndexingStatus never shows.
The empty object was breaking the UI since `schema.object({})` is actually an empty object. This is more explicit and correct.
scottybollinger
added
Feature:Plugins
v8.0.0
release_note:skip
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
yakhinvadim
approved these changes
Dec 3, 2020
Contributor
yakhinvadim
left a comment
yakhinvadim
left a comment
There was a problem hiding this comment.
LGTM 👍 , only 1 question:
| hasErrors?: boolean; | ||
| } | ||
|
|
||
| export type TOperation = typeof ADD | typeof UPDATE; |
Contributor
There was a problem hiding this comment.
Should we remove T in the type name?
If yes, feel free to merge and fix in later PRs.
Contributor
Author
There was a problem hiding this comment.
Thanks. Will address this in a follow-up PR.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 4, 2020
* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the ContentSources Schema tree from
ent-search.Checklist