[Metrics UI] Add metadata tab to node details flyout by phillipb · Pull Request #84454 · elastic/kibana

phillipb · 2020-11-27T16:59:24Z

Summary

Add metadata tab to the node details flyout. Update metadata api to return more fields.
Only show the overlay for hosts
Add "Open as new page" functionality to overlay

Closes #80306

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

elasticmachine · 2020-11-27T16:59:26Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

phillipb · 2020-11-28T22:07:17Z

@elasticmachine merge upstream

…bana into add-metadata-to-node-details * 'add-metadata-to-node-details' of github.com:phillipb/kibana: skip flaky suite (elastic#84440)

phillipb · 2020-11-30T15:43:59Z

@elasticmachine merge upstream

…bana into add-metadata-to-node-details * 'add-metadata-to-node-details' of github.com:phillipb/kibana: [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) [ML] Renaming saved object repair to sync (elastic#84311) [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313) [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456) [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322) TSVB field list performance issue on using annotations (elastic#84407) [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)

Zacqary

Code looks good and works, one issue I found is that I can still click View event with filter on values that come back undefined. Maybe remove undefined values from the table entirely?

.../infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx

phillipb · 2020-12-02T22:26:55Z

@elasticmachine merge upstream

kibanamachine · 2020-12-03T14:47:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4f6b8db

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1051	1079	+28

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	2.6MB	2.7MB	+104.8KB

History

💚 Build #91549 succeeded 8b70611
💚 Build #91258 succeeded c2da6f5
💚 Build #91252 succeeded 161a80e
💚 Build #91076 succeeded 25e23ed
💔 Build #91029 failed ceaac8c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Zacqary

LGTM

Zacqary · 2020-12-03T18:01:32Z

.../public/pages/metrics/inventory_view/components/node_details/tabs/properties/build_fields.ts

 };
+
+const prune = (fields: Array<{ name: string; value: string | string[] | undefined }>) =>
+  fields.filter((f) => !!f.value);


I usually like doing filter(Boolean) for added clarity, since !! can sometimes be mistaken for a typo, but this is fine

* Add properties tab to flyout * Better id for i18n title * Update i18n ids * Fix test and styling * Style changes, add support for collapsing array fields * Add loading indicators * Fix type check * Fix another test * Fix tests for pods * Add link to node details page * Only show the overlay when viewing hosts * Take into account cores when showing cpu * Make it easier to read * Remove unnecessary cast * Fix PR feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...

* Add properties tab to flyout * Better id for i18n title * Update i18n ids * Fix test and styling * Style changes, add support for collapsing array fields * Add loading indicators * Fix type check * Fix another test * Fix tests for pods * Add link to node details page * Only show the overlay when viewing hosts * Take into account cores when showing cpu * Make it easier to read * Remove unnecessary cast * Fix PR feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Add properties tab to flyout

2e5954b

phillipb added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Nov 27, 2020

phillipb requested a review from a team as a code owner November 27, 2020 16:59

phillipb added 2 commits November 27, 2020 11:08

Better id for i18n title

05c7a3b

Update i18n ids

2fbd2b2

kibanamachine and others added 4 commits November 28, 2020 17:07

Merge branch 'master' into add-metadata-to-node-details

638223c

Fix test and styling

b09a778

Merge branch 'add-metadata-to-node-details' of github.com:phillipb/ki…

29b87ad

…bana into add-metadata-to-node-details * 'add-metadata-to-node-details' of github.com:phillipb/kibana: skip flaky suite (elastic#84440)

Style changes, add support for collapsing array fields

3bf8172

kibanamachine and others added 11 commits November 30, 2020 10:44

Merge branch 'master' into add-metadata-to-node-details

2a9621f

Add loading indicators

2a6b58b

Fix type check

d55787e

Fix another test

c6e1d99

Fix tests for pods

84e95ae

Add link to node details page

ceaac8c

Only show the overlay when viewing hosts

25e23ed

Take into account cores when showing cpu

161a80e

Make it easier to read

a7a7f13

Remove unnecessary cast

c2da6f5

Zacqary requested changes Dec 2, 2020

View reviewed changes

.../infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx Outdated Show resolved Hide resolved

Merge branch 'master' into add-metadata-to-node-details

8b70611

Fix PR feedback

4f6b8db

phillipb requested a review from Zacqary December 3, 2020 17:17

Zacqary approved these changes Dec 3, 2020

View reviewed changes

phillipb merged commit 61fdec2 into elastic:master Dec 3, 2020

phillipb mentioned this pull request Dec 3, 2020

[7.x] [Metrics UI] Add metadata tab to node details flyout (#84454) #84971

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metrics UI] Add metadata tab to node details flyout#84454

[Metrics UI] Add metadata tab to node details flyout#84454
phillipb merged 20 commits intoelastic:masterfrom
phillipb:add-metadata-to-node-details

phillipb commented Nov 27, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Nov 27, 2020

Uh oh!

phillipb commented Nov 28, 2020

Uh oh!

phillipb commented Nov 30, 2020

Uh oh!

Zacqary left a comment

Uh oh!

Uh oh!

phillipb commented Dec 2, 2020

Uh oh!

kibanamachine commented Dec 3, 2020

Uh oh!

Zacqary left a comment

Uh oh!

Zacqary Dec 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

phillipb commented Nov 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Nov 27, 2020

Uh oh!

phillipb commented Nov 28, 2020

Uh oh!

phillipb commented Nov 30, 2020

Uh oh!

Zacqary left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phillipb commented Dec 2, 2020

Uh oh!

kibanamachine commented Dec 3, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Zacqary left a comment

Choose a reason for hiding this comment

Uh oh!

Zacqary Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

phillipb commented Nov 27, 2020 •

edited

Loading