[APM] Add APM agent config options by eyalkoren · Pull Request #84678 · elastic/kibana

eyalkoren · 2020-12-01T16:31:00Z

Summary

Closes elastic/apm#369

Added

`sanitize_field_names`

`transaction_ignore_urls`

Modified

`log_level`

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility
Tested manually on Chrome
Functionality verified using the APM Java agent

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-12-01T16:31:05Z

Pinging @elastic/apm-ui (Team:apm)

bmorelli25

Content/wording LGTM

sorenlouv · 2020-12-02T17:19:32Z

@elasticmachine merge upstream

sorenlouv

Great work, thanks @eyalkoren !

eyalkoren · 2020-12-03T07:51:33Z

@elasticmachine merge upstream

(I figured it is required due to the merge of #83425)

kibanamachine · 2020-12-03T09:33:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6e6596d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1152	1153	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.1MB	3.1MB	+2.3KB

Distributable file count

id	before	after	diff
`default`	43460	43461	+1

History

💚 Build #91441 succeeded ff621ff
💚 Build #91271 succeeded a7792a4
💔 Build #91195 failed ce8c4e3
💔 Build #91115 failed 96b1302
💔 Build #91100 failed 7f0d95b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (40 commits) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992) [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006) ...

* master: (236 commits) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992) [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006) ...

…overy-action-group * upstream/master: (48 commits) [Lens] accessibility screen reader issues (elastic#84395) [Logs UI] Fetch single log entries via a search strategy (elastic#81710) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) ...

[APM] Add APM agent config options

7f0d95b

eyalkoren requested review from a team and bmorelli25 December 1, 2020 16:31

eyalkoren self-assigned this Dec 1, 2020

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Dec 1, 2020

eyalkoren added release_note:enhancement v7.11 v7.11.0 and removed v7.11 labels Dec 1, 2020

eyalkoren added 3 commits December 1, 2020 18:56

Fix i18n labels

22987b7

Update test

96b1302

Fix test

ce8c4e3

bmorelli25 reviewed Dec 1, 2020

View reviewed changes

bmorelli25 requested a review from a team December 1, 2020 20:30

Add runtime type and fix anther test

a7792a4

sorenlouv approved these changes Dec 2, 2020

View reviewed changes

Merge branch 'master' into apm-agent-configs

ff621ff

basepi mentioned this pull request Dec 2, 2020

[APM] Add log_level/sanitize_field_names config options to Python Agent #84810

Merged

1 task

Merge branch 'master' into apm-agent-configs

6e6596d

eyalkoren merged commit f5fb14f into elastic:master Dec 3, 2020

eyalkoren deleted the apm-agent-configs branch December 3, 2020 10:39

This was referenced Dec 3, 2020

[META 319] Add sanitize_field_name option to Kibana elastic/apm-agent-java#1504

Closed

[META 321] Add log_level option to central Kibana configuration elastic/apm-agent-java#1509

Closed

eyalkoren mentioned this pull request Dec 3, 2020

[7.x] [APM] Add APM agent config options (#84678) #84889

Merged

eyalkoren added a commit to eyalkoren/kibana that referenced this pull request Dec 3, 2020

[APM] Add APM agent config options (elastic#84678)

fa8f775

eyalkoren added a commit that referenced this pull request Dec 3, 2020

[APM] Add APM agent config options (#84678) (#84889)

b9e0552

trentm mentioned this pull request Dec 4, 2020

Document new 7.11 central config vars as Central/Dynamic Configuration elastic/apm-agent-nodejs#1883

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add APM agent config options#84678

[APM] Add APM agent config options#84678
eyalkoren merged 7 commits intoelastic:masterfrom
eyalkoren:apm-agent-configs

eyalkoren commented Dec 1, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Dec 1, 2020

Uh oh!

bmorelli25 left a comment

Uh oh!

sorenlouv commented Dec 2, 2020

Uh oh!

sorenlouv left a comment

Uh oh!

eyalkoren commented Dec 3, 2020

Uh oh!

kibanamachine commented Dec 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

eyalkoren commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Added

sanitize_field_names

transaction_ignore_urls

Modified

log_level

Checklist

For maintainers

Uh oh!

elasticmachine commented Dec 1, 2020

Uh oh!

bmorelli25 left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv commented Dec 2, 2020

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

eyalkoren commented Dec 3, 2020

Uh oh!

kibanamachine commented Dec 3, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eyalkoren commented Dec 1, 2020 •

edited

Loading

`sanitize_field_names`

`transaction_ignore_urls`

`log_level`