[uiSettings]: Migrate items owned by app arch to new platform by VladLasitsa · Pull Request #66040 · elastic/kibana

VladLasitsa · 2020-05-11T14:27:43Z

Closes #63480

Summary

Migrated uiSettings items to new platform:

query:queryString:options 👉 data
query:allowLeadingWildcards 👉 data
search:queryLanguage 👉 data
sort:options 👉 data
defaultIndex 👉data
courier:ignoreFilterIfFieldNotInIndex 👉data
courier:setRequestPreference 👉data
courier:customRequestPreference 👉data
courier:maxConcurrentShardRequests 👉data
courier:batchSearches 👉data
search:includeFrozen 👉data
histogram:barTarget 👉data
histogram:maxBars 👉data
visualize:enableLabs 👉visualizations
csv:separator 👉share
csv:quoteValues 👉share
history:limit 👉data
shortDots:enable 👉data
format:defaultTypeMap 👉data
format:number:defaultPattern 👉data
format:bytes:defaultPattern 👉data
format:percent:defaultPattern 👉data
format:currency:defaultPattern 👉data
format:number:defaultLocale 👉data
timepicker:refreshIntervalDefaults 👉data
timepicker:quickRanges 👉data
indexPattern:placeholder 👉data
filters:pinnedByDefault 👉data
filterEditor:suggestValues 👉data

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-05-11T14:29:16Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

VladLasitsa · 2020-05-12T08:11:25Z

@elasticmachine merge upstream

src/plugins/kibana_utils/server/index.ts

alexwizp · 2020-05-12T11:44:47Z

src/plugins/data/server/ui_settings.ts

+          setRequestReferenceSetting: '<strong>courier:setRequestPreference</strong>',
+          customSettingValue: '"custom"',
+          requestPreferenceLink:
+            '<a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-preference.html" target="_blank" rel="noopener">' +


@lukeelmers not sure that it's related to current PR, but it looks like an issue which should be addressed in future.
We should get links from DocLinks service (src/core/public/doc_links/doc_links_service.ts) instead of hardcoding it.

We should get links from DocLinks service (src/core/public/doc_links/doc_links_service.ts) instead of hardcoding it.

Yes, agreed. The problem right now is that docLinks is not available in CoreSetup. I have a PR up to expose it in setup so we could use it here.

Once that's merged we can add these links to the docLinks service, as I don't see them there right now.

I created #67026 to track updating docLinks as a follow-up task.

VladLasitsa · 2020-05-13T15:36:03Z

@elasticmachine merge upstream

alexwizp · 2020-05-14T17:49:03Z

@elasticmachine merge upstream

VladLasitsa · 2020-05-26T13:55:42Z

@elasticmachine merge upstream

VladLasitsa · 2020-05-29T10:15:10Z

@elasticmachine merge upstream

VladLasitsa · 2020-06-01T08:42:43Z

@elasticmachine merge upstream

VladLasitsa · 2020-06-01T11:45:19Z

@elasticmachine merge upstream

crob611

Canvas code looks good 👍

lukeelmers · 2020-06-03T14:32:44Z

@elasticmachine merge upstream

# Conflicts: # x-pack/plugins/reporting/server/export_types/csv/server/execute_job.test.ts # x-pack/plugins/reporting/server/export_types/csv/server/execute_job.ts # x-pack/plugins/reporting/server/export_types/csv_from_savedobject/server/lib/generate_csv_search.ts # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

# Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md

kibanamachine · 2020-06-04T16:25:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1fc25c4

History

💔 Build #51715 failed 7e3af14c8ec7e7df4de3ab699d0532446fbaa549
💔 Build #51680 failed 450e179
💚 Build #51409 succeeded 166d00c
💚 Build #50762 succeeded ab24186
💚 Build #50521 succeeded 2fcc681

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jasonrhodes

Assuming UI_SETTINGS.* are just strings being swapped in for our hard-coded ones, this LGTM!

igoristic

Stack Monitoring looks good from code pov 👍

@VladLasitsa
Though I couldn't test the branch locally since I kept getting:

 FATAL  Error: Setup lifecycle of "reporting" plugin wasn't completed in 30sec. Consider disabling the plugin and re-start.

 server crashed  with status code 1

…c#66040) * Migrated uiSettings items to new platform * API changes * Fixed translations * Fixed comment and i18n * Fixed tests * Fixed internalization * Fix karma tests * made code more explicit * Fixed plugin * Added consts for ui settings ids. * Added id for another settings * Fixed tests. * Improved imports * Fix imports to public which were happening from the server. * Fixed paths * Moved styles to plugin.ts * Moved styles * Fixed docs * Fix ci * Fix ci * fix documentation Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> # Conflicts: # src/legacy/core_plugins/kibana/server/ui_setting_defaults.js

#68354) * Migrated uiSettings items to new platform * API changes * Fixed translations * Fixed comment and i18n * Fixed tests * Fixed internalization * Fix karma tests * made code more explicit * Fixed plugin * Added consts for ui settings ids. * Added id for another settings * Fixed tests. * Improved imports * Fix imports to public which were happening from the server. * Fixed paths * Moved styles to plugin.ts * Moved styles * Fixed docs * Fix ci * Fix ci * fix documentation Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> # Conflicts: # src/legacy/core_plugins/kibana/server/ui_setting_defaults.js Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>

Migrated uiSettings items to new platform

0139a50

VladLasitsa requested a review from alexwizp May 11, 2020 14:27

VladLasitsa self-assigned this May 11, 2020

VladLasitsa added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.9.0 v8.0.0 labels May 11, 2020

API changes

96c72ab

Merge branch 'master' into elastic#63480

3648b8a

alexwizp reviewed May 12, 2020

View reviewed changes

src/plugins/kibana_utils/server/index.ts Outdated Show resolved Hide resolved

Fixed translations

ef23395

alexwizp reviewed May 12, 2020

View reviewed changes

VladLasitsa added 2 commits May 12, 2020 14:48

Merge remote-tracking branch 'origin/elastic#63480' into elastic#63480

807d1e9

Fixed comment and i18n

bb2cef9

VladLasitsa marked this pull request as ready for review May 12, 2020 15:29

VladLasitsa requested a review from a team as a code owner May 12, 2020 15:29

VladLasitsa added 3 commits May 13, 2020 12:14

Fixed tests

b546477

Merge remote-tracking branch 'upstream/master' into elastic#63480

9e0e394

Fixed internalization

d583b5a

VladLasitsa force-pushed the #63480 branch from b26add2 to d583b5a Compare May 13, 2020 13:37

elasticmachine and others added 2 commits May 13, 2020 08:36

Merge branch 'master' into elastic#63480

8327398

Merge remote-tracking branch 'upstream/master' into elastic#63480

ab6aaf3

alexwizp force-pushed the #63480 branch from 5f63085 to b0ee1a6 Compare May 14, 2020 13:19

Fix karma tests

54a961e

alexwizp force-pushed the #63480 branch from b0ee1a6 to 54a961e Compare May 14, 2020 13:22

elasticmachine and others added 4 commits May 26, 2020 06:55

Merge branch 'master' into elastic#63480

e28dea8

Moved styles

b83e536

Merge remote-tracking branch 'upstream/master' into elastic#63480

5871430

Fixed docs

22fdddb

Dosant mentioned this pull request May 27, 2020

[discuss] Deprecate state:storeInSessionStorage? #67454

Closed

VladLasitsa added 2 commits May 27, 2020 15:14

Fix ci

f9a3c72

Fix ci

428a4a5

Merge branch 'master' into elastic#63480

2fcc681

Merge branch 'master' into elastic#63480

ab24186

crob611 approved these changes Jun 2, 2020

View reviewed changes

jonathan-buttner approved these changes Jun 3, 2020

View reviewed changes

elasticmachine and others added 4 commits June 3, 2020 07:32

Merge branch 'master' into elastic#63480

166d00c

Merge remote-tracking branch 'upstream/master' into elastic#63480

434dcda

# Conflicts: # src/plugins/data/public/public.api.md # src/plugins/data/server/server.api.md

fix documentation

1fc25c4

alexwizp force-pushed the #63480 branch from 7e3af14 to 1fc25c4 Compare June 4, 2020 14:44

jasonrhodes approved these changes Jun 4, 2020

View reviewed changes

igoristic approved these changes Jun 4, 2020

View reviewed changes

alexwizp merged commit b87eefc into elastic:master Jun 5, 2020

alexwizp mentioned this pull request Jun 5, 2020

[7.x] [uiSettings]: Migrate items owned by app arch to new platform (#66040) #68354

Merged

alexwizp mentioned this pull request Jun 5, 2020

Removes noreferrer on explicit elastic.co domains #31008

Merged

4 tasks

dokmic mentioned this pull request Sep 8, 2022

[Timepicker] Align the timepicker:refreshIntervalDefaults setting with the documentation #140249

Closed

Conversation

VladLasitsa commented May 11, 2020 • edited by lukeelmers Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented May 11, 2020

Uh oh!

VladLasitsa commented May 12, 2020

Uh oh!

Uh oh!

alexwizp May 12, 2020

Choose a reason for hiding this comment

Uh oh!

lukeelmers May 14, 2020

Choose a reason for hiding this comment

Uh oh!

lukeelmers May 19, 2020

Choose a reason for hiding this comment

Uh oh!

VladLasitsa commented May 13, 2020

Uh oh!

alexwizp commented May 14, 2020

Uh oh!

VladLasitsa commented May 26, 2020

Uh oh!

VladLasitsa commented May 29, 2020

Uh oh!

VladLasitsa commented Jun 1, 2020

Uh oh!

VladLasitsa commented Jun 1, 2020

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

lukeelmers commented Jun 3, 2020

Uh oh!

kibanamachine commented Jun 4, 2020

💚 Build Succeeded

History

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

igoristic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

VladLasitsa commented May 11, 2020 •

edited by lukeelmers

Loading

igoristic left a comment •

edited

Loading