[uiSettings]: Migrate items owned by app arch to new platform

src/legacy/core_plugins/timelion/public/directives/saved_object_finder.js

@@ -29,6 +29,7 @@ import {
   PaginateDirectiveProvider,
 } from '../../../../../plugins/kibana_legacy/public';
 import { PER_PAGE_SETTING } from '../../../../../plugins/saved_objects/common';
+import { VISUALIZE_ENABLE_LABS_SETTINGS } from '../../../../../plugins/visualizations/common/constants';
 
 const module = uiModules.get('kibana');
 
@@ -296,7 +297,7 @@ module
 
           prevSearch = filter;
 
-          const isLabsEnabled = config.get('visualize:enableLabs');
+          const isLabsEnabled = config.get(VISUALIZE_ENABLE_LABS_SETTINGS);
           self.service.find(filter).then(function(hits) {
             hits.hits = hits.hits.filter(
               hit => isLabsEnabled || _.get(hit, 'type.stage') !== 'experimental'

src/legacy/ui/public/new_platform/new_platform.karma_mock.js

@@ -28,6 +28,22 @@ import {
   // eslint-disable-next-line @kbn/eslint/no-restricted-paths
 } from '../../../../../src/plugins/data/public/search/aggs';
 import { ComponentRegistry } from '../../../../../src/plugins/advanced_settings/public/';
+import {
+  QUERY_STRING_OPTIONS_SETTINGS,
+  QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS,
+  SEARCH_QUERY_LANGUAGE_SETTINGS,
+  COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS,
+  SHORT_DOTS_ENABLE_SETTINGS,
+  FORMAT_DEFAULT_TYPE_MAP_SETTINGS,
+  FORMAT_NUMBER_DEFAULT_PATTERN_SETTINGS,
+  FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS,
+  FORMAT_CURRENCY_DEFAULT_PATTERN_SETTINGS,
+  FORMAT_NUMBER_DEFAULT_LOCALE_SETTINGS,
+} from '../../../../../src/plugins/data/common';
+import {
+  CSV_SEPARATOR_SETTINGS,
+  CSV_QUOTE_VALUES_SETTINGS,
+} from '../../../../../src/plugins/share/common/constants';
 
 const mockObservable = () => {
   return {
@@ -49,18 +65,31 @@ let isTimeRangeSelectorEnabled = true;
 let isAutoRefreshSelectorEnabled = true;
 
 export const mockUiSettings = {
-  get: item => {
-    return mockUiSettings[item];
+  get: (item, defaultValue) => {
+    const defaultValues = {
+      dateFormat: 'MMM D, YYYY @ HH:mm:ss.SSS',
+      'dateFormat:tz': 'UTC',
+      [SHORT_DOTS_ENABLE_SETTINGS]: true,
+      [COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS]: true,
+      [QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS]: true,
+      [QUERY_STRING_OPTIONS_SETTINGS]: {},
+      [FORMAT_CURRENCY_DEFAULT_PATTERN_SETTINGS]: '($0,0.[00])',
+      [FORMAT_NUMBER_DEFAULT_PATTERN_SETTINGS]: '0,0.[000]',
+      [FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS]: '0,0.[000]%',
+      [FORMAT_NUMBER_DEFAULT_LOCALE_SETTINGS]: 'en',
+      [FORMAT_DEFAULT_TYPE_MAP_SETTINGS]: {},
+      [CSV_SEPARATOR_SETTINGS]: ',',
+      [CSV_QUOTE_VALUES_SETTINGS]: true,
+      [SEARCH_QUERY_LANGUAGE_SETTINGS]: 'kuery',
+      'state:storeInSessionStorage': false,
+    };
+
+    return defaultValues[item] || defaultValue;
   },
   getUpdate$: () => ({
     subscribe: sinon.fake(),
   }),
   isDefault: sinon.fake(),
-  'query:allowLeadingWildcards': true,
-  'query:queryString:options': {},
-  'courier:ignoreFilterIfFieldNotInIndex': true,
-  'dateFormat:tz': 'Browser',
-  'format:defaultTypeMap': {},
 };
 
 const mockCoreSetup = {
@@ -524,6 +553,8 @@ export function __setup__(coreSetup) {
   // bootstrap an LP plugin outside of tests)
   npSetup.core.application.register = () => {};
 
+  npSetup.core.uiSettings.get = mockUiSettings.get;
+
   // Services that need to be set in the legacy platform since the legacy data
   // & vis plugins which previously provided them have been removed.
   setSetupServices(npSetup);
@@ -532,6 +563,8 @@ export function __setup__(coreSetup) {
 export function __start__(coreStart) {
   npStart.core = coreStart;
 
+  npStart.core.uiSettings.get = mockUiSettings.get;
+
   // Services that need to be set in the legacy platform since the legacy data
   // & vis plugins which previously provided them have been removed.
   setStartServices(npStart);

src/legacy/ui/public/timefilter/setup_router.ts

@@ -25,6 +25,7 @@ import { RefreshInterval, TimeRange, TimefilterContract } from 'src/plugins/data
 import { Subscription } from 'rxjs';
 import { fatalError } from 'ui/notify/fatal_error';
 import { subscribeWithScope } from '../../../../plugins/kibana_legacy/public';
+import { TIMEPICKER_REFRESH_INTERVAL_DEFAULTS_SETTINGS } from '../../../../plugins/data/common';
 
 // TODO
 // remove everything underneath once globalState is no longer an angular service
@@ -38,7 +39,7 @@ export function getTimefilterConfig() {
   const settings = chrome.getUiSettingsClient();
   return {
     timeDefaults: settings.get('timepicker:timeDefaults'),
-    refreshIntervalDefaults: settings.get('timepicker:refreshIntervalDefaults'),
+    refreshIntervalDefaults: settings.get(TIMEPICKER_REFRESH_INTERVAL_DEFAULTS_SETTINGS),
   };
 }
 

src/plugins/dashboard/public/application/dashboard_app_controller.tsx

@@ -42,6 +42,7 @@ import {
   SavedQuery,
   syncQueryStateWithUrl,
 } from '../../../data/public';
+import { SEARCH_QUERY_LANGUAGE_SETTINGS } from '../../../data/common';
 import { getSavedObjectFinder, SaveResult, showSaveModal } from '../../../saved_objects/public';
 
 import {
@@ -430,7 +431,8 @@ export class DashboardAppController {
       dashboardStateManager.getQuery() || {
         query: '',
         language:
-          localStorage.get('kibana.userQueryLanguage') || uiSettings.get('search:queryLanguage'),
+          localStorage.get('kibana.userQueryLanguage') ||
+          uiSettings.get(SEARCH_QUERY_LANGUAGE_SETTINGS),
       },
       queryFilter.getFilters()
     );

src/plugins/data/common/constants.ts

@@ -20,3 +20,29 @@
 export const DEFAULT_QUERY_LANGUAGE = 'kuery';
 export const META_FIELDS_SETTING = 'metaFields';
 export const DOC_HIGHLIGHT_SETTING = 'doc_table:highlight';
+export const QUERY_STRING_OPTIONS_SETTINGS = 'query:queryString:options';
+export const QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS = 'query:allowLeadingWildcards';
+export const SEARCH_QUERY_LANGUAGE_SETTINGS = 'search:queryLanguage';
+export const SORT_OPTIONS_SETTINGS = 'sort:options';
+export const COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS =
+  'courier:ignoreFilterIfFieldNotInIndex';
+export const COURIER_SET_REQUEST_PREFERENCE_SETTINGS = 'courier:setRequestPreference';
+export const COURIER_CUSTOM_REQUEST_PREFERENCE_SETTINGS = 'courier:customRequestPreference';
+export const COURIER_MAX_CONCURRENT_SHARD_REQUESTS_SETTINGS = 'courier:maxConcurrentShardRequests';
+export const COURIER_BATCH_SEARCHES_SETTINGS = 'courier:batchSearches';
+export const SEARCH_INCLUDE_FROZEN_SETTINGS = 'search:includeFrozen';
+export const HISTOGRAM_BAR_TARGET_SETTINGS = 'histogram:barTarget';
+export const HISTOGRAM_MAX_BARS_SETTINGS = 'histogram:maxBars';
+export const HISTORY_LIMIT_SETTINGS = 'history:limit';
+export const SHORT_DOTS_ENABLE_SETTINGS = 'shortDots:enable';
+export const FORMAT_DEFAULT_TYPE_MAP_SETTINGS = 'format:defaultTypeMap';
+export const FORMAT_NUMBER_DEFAULT_PATTERN_SETTINGS = 'format:number:defaultPattern';
+export const FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS = 'format:percent:defaultPattern';
+export const FORMAT_BYTES_DEFAULT_PATTERN_SETTINGS = 'format:bytes:defaultPattern';
+export const FORMAT_CURRENCY_DEFAULT_PATTERN_SETTINGS = 'format:currency:defaultPattern';
+export const FORMAT_NUMBER_DEFAULT_LOCALE_SETTINGS = 'format:number:defaultLocale';
+export const TIMEPICKER_REFRESH_INTERVAL_DEFAULTS_SETTINGS = 'timepicker:refreshIntervalDefaults';
+export const TIMEPICKER_QUICK_RANGES_SETTINGS = 'timepicker:quickRanges';
+export const INDEXPATTERN_PLACEHOLDER_SETTINGS = 'indexPattern:placeholder';
+export const FILTERS_PINNED_BY_DEFAULT_SETTINGS = 'filters:pinnedByDefault';
+export const FILTERS_EDITOR_SUGGEST_VALUES_SETTINGS = 'filterEditor:suggestValues';

src/plugins/data/common/es_query/es_query/get_es_query_config.test.ts

@@ -19,18 +19,23 @@
 import { get } from 'lodash';
 import { getEsQueryConfig } from './get_es_query_config';
 import { IUiSettingsClient } from 'kibana/public';
+import {
+  QUERY_STRING_OPTIONS_SETTINGS,
+  QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS,
+  COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS,
+} from '../../';
 
 const config = ({
   get(item: string) {
     return get(config, item);
   },
-  'query:allowLeadingWildcards': {
+  [QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS]: {
     allowLeadingWildcards: true,
   },
-  'query:queryString:options': {
+  [QUERY_STRING_OPTIONS_SETTINGS]: {
     queryStringOptions: {},
   },
-  'courier:ignoreFilterIfFieldNotInIndex': {
+  [COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS]: {
     ignoreFilterIfFieldNotInIndex: true,
   },
   'dateFormat:tz': {

src/plugins/data/common/es_query/es_query/get_es_query_config.ts

@@ -18,15 +18,22 @@
  */
 
 import { EsQueryConfig } from './build_es_query';
+import {
+  QUERY_STRING_OPTIONS_SETTINGS,
+  QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS,
+  COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS,
+} from '../../';
 
 interface KibanaConfig {
   get<T>(key: string): T;
 }
 
 export function getEsQueryConfig(config: KibanaConfig) {
-  const allowLeadingWildcards = config.get('query:allowLeadingWildcards');
-  const queryStringOptions = config.get('query:queryString:options');
-  const ignoreFilterIfFieldNotInIndex = config.get('courier:ignoreFilterIfFieldNotInIndex');
+  const allowLeadingWildcards = config.get(QUERY_ALLOW_LEADING_WILDCARDS_SETTINGS);
+  const queryStringOptions = config.get(QUERY_STRING_OPTIONS_SETTINGS);
+  const ignoreFilterIfFieldNotInIndex = config.get(
+    COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX_SETTINGS
+  );
   const dateFormatTZ = config.get('dateFormat:tz');
 
   return {

src/plugins/data/common/field_formats/converters/bytes.test.ts

@@ -18,11 +18,12 @@
  */
 
 import { BytesFormat } from './bytes';
+import { FORMAT_BYTES_DEFAULT_PATTERN_SETTINGS } from '../../';
 
 describe('BytesFormat', () => {
   const config: Record<string, any> = {};
 
-  config['format:bytes:defaultPattern'] = '0,0.[000]b';
+  config[FORMAT_BYTES_DEFAULT_PATTERN_SETTINGS] = '0,0.[000]b';
 
   const getConfig = (key: string) => config[key];
 

src/plugins/data/common/field_formats/converters/number.test.ts

@@ -18,11 +18,12 @@
  */
 
 import { NumberFormat } from './number';
+import { FORMAT_NUMBER_DEFAULT_PATTERN_SETTINGS } from '../../';
 
 describe('NumberFormat', () => {
   const config: Record<string, any> = {};
 
-  config['format:number:defaultPattern'] = '0,0.[000]';
+  config[FORMAT_NUMBER_DEFAULT_PATTERN_SETTINGS] = '0,0.[000]';
 
   const getConfig = (key: string) => config[key];
 

src/plugins/data/common/field_formats/converters/numeral.ts

@@ -24,6 +24,7 @@ import numeralLanguages from '@elastic/numeral/languages';
 import { KBN_FIELD_TYPES } from '../../kbn_field_types/types';
 import { FieldFormat } from '../field_format';
 import { TextContextTypeConvert } from '../types';
+import { FORMAT_NUMBER_DEFAULT_LOCALE_SETTINGS } from '../../';
 
 const numeralInst = numeral();
 
@@ -51,7 +52,8 @@ export abstract class NumeralFormat extends FieldFormat {
     if (isNaN(val)) return '';
 
     const previousLocale = numeral.language();
-    const defaultLocale = (this.getConfig && this.getConfig('format:number:defaultLocale')) || 'en';
+    const defaultLocale =
+      (this.getConfig && this.getConfig(FORMAT_NUMBER_DEFAULT_LOCALE_SETTINGS)) || 'en';
     numeral.language(defaultLocale);
 
     const formatted = numeralInst.set(val).format(this.param('pattern'));

src/plugins/data/common/field_formats/converters/percent.test.ts

@@ -18,11 +18,12 @@
  */
 
 import { PercentFormat } from './percent';
+import { FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS } from '../../';
 
 describe('PercentFormat', () => {
   const config: Record<string, any> = {};
 
-  config['format:percent:defaultPattern'] = '0,0.[000]%';
+  config[FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS] = '0,0.[000]%';
 
   const getConfig = (key: string) => config[key];
 

src/plugins/data/common/field_formats/converters/percent.ts

@@ -20,6 +20,7 @@
 import { i18n } from '@kbn/i18n';
 import { NumeralFormat } from './numeral';
 import { TextContextTypeConvert, FIELD_FORMAT_IDS } from '../types';
+import { FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS } from '../../';
 
 export class PercentFormat extends NumeralFormat {
   static id = FIELD_FORMAT_IDS.PERCENT;
@@ -32,7 +33,7 @@ export class PercentFormat extends NumeralFormat {
   allowsNumericalAggregations = true;
 
   getParamDefaults = () => ({
-    pattern: this.getConfig!('format:percent:defaultPattern'),
+    pattern: this.getConfig!(FORMAT_PERCENT_DEFAULT_PATTERN_SETTINGS),
     fractional: true,
   });
 

src/plugins/data/common/field_formats/converters/source.ts

@@ -22,6 +22,7 @@ import { shortenDottedString } from '../../utils';
 import { KBN_FIELD_TYPES } from '../../kbn_field_types/types';
 import { FieldFormat } from '../field_format';
 import { TextContextTypeConvert, HtmlContextTypeConvert, FIELD_FORMAT_IDS } from '../types';
+import { SHORT_DOTS_ENABLE_SETTINGS } from '../../';
 
 /**
  * Remove all of the whitespace between html tags
@@ -71,7 +72,7 @@ export class SourceFormat extends FieldFormat {
     const formatted = field.indexPattern.formatHit(hit);
     const highlightPairs: any[] = [];
     const sourcePairs: any[] = [];
-    const isShortDots = this.getConfig!('shortDots:enable');
+    const isShortDots = this.getConfig!(SHORT_DOTS_ENABLE_SETTINGS);
 
     keys(formatted).forEach(key => {
       const pairs = highlights[key] ? highlightPairs : sourcePairs;

src/plugins/data/common/field_formats/field_formats_registry.ts

@@ -33,6 +33,7 @@ import { baseFormatters } from './constants/base_formatters';
 import { FieldFormat } from './field_format';
 import { SerializedFieldFormat } from '../../../expressions/common/types';
 import { ES_FIELD_TYPES, KBN_FIELD_TYPES } from '../types';
+import { FORMAT_DEFAULT_TYPE_MAP_SETTINGS } from '../';
 
 export class FieldFormatsRegistry {
   protected fieldFormats: Map<FieldFormatId, FieldFormatInstanceType> = new Map();
@@ -49,7 +50,7 @@ export class FieldFormatsRegistry {
     metaParamsOptions: Record<string, any> = {},
     defaultFieldConverters: FieldFormatInstanceType[] = baseFormatters
   ) {
-    const defaultTypeMap = getConfig('format:defaultTypeMap');
+    const defaultTypeMap = getConfig(FORMAT_DEFAULT_TYPE_MAP_SETTINGS);
     this.register(defaultFieldConverters);
     this.parseDefaultTypeMap(defaultTypeMap);
     this.getConfig = getConfig;

src/plugins/data/public/autocomplete/providers/value_suggestion_provider.ts

@@ -19,7 +19,7 @@
 
 import { memoize } from 'lodash';
 import { CoreSetup } from 'src/core/public';
-import { IIndexPattern, IFieldType } from '../../../common';
+import { IIndexPattern, IFieldType, FILTERS_EDITOR_SUGGEST_VALUES_SETTINGS } from '../../../common';
 
 function resolver(title: string, field: IFieldType, query: string, boolFilter: any) {
   // Only cache results for a minute
@@ -56,7 +56,9 @@ export const setupValueSuggestionProvider = (core: CoreSetup): ValueSuggestionsG
     boolFilter,
     signal,
   }: ValueSuggestionsGetFnArgs): Promise<any[]> => {
-    const shouldSuggestValues = core!.uiSettings.get<boolean>('filterEditor:suggestValues');
+    const shouldSuggestValues = core!.uiSettings.get<boolean>(
+      FILTERS_EDITOR_SUGGEST_VALUES_SETTINGS
+    );
     const { title } = indexPattern;
 
     if (field.type === 'boolean') {

src/plugins/data/public/field_formats/field_formats_service.ts

@@ -18,7 +18,7 @@
  */
 
 import { CoreSetup } from 'src/core/public';
-import { FieldFormatsRegistry } from '../../common';
+import { FieldFormatsRegistry, FORMAT_DEFAULT_TYPE_MAP_SETTINGS } from '../../common';
 import { deserializeFieldFormat } from './utils/deserialize';
 import { FormatFactory } from '../../common/field_formats/utils';
 import { baseFormattersPublic } from './constants';
@@ -28,7 +28,7 @@ export class FieldFormatsService {
 
   public setup(core: CoreSetup) {
     core.uiSettings.getUpdate$().subscribe(({ key, newValue }) => {
-      if (key === 'format:defaultTypeMap') {
+      if (key === FORMAT_DEFAULT_TYPE_MAP_SETTINGS) {
         this.fieldFormatsRegistry.parseDefaultTypeMap(newValue);
       }
     });

src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts

@@ -34,6 +34,7 @@ import {
   IIndexPattern,
   IFieldType,
   META_FIELDS_SETTING,
+  SHORT_DOTS_ENABLE_SETTINGS,
 } from '../../../common';
 import { findByTitle } from '../utils';
 import { IndexPatternMissingIndices } from '../lib';
@@ -108,7 +109,7 @@ export class IndexPattern implements IIndexPattern {
     // which cause problems when being consumed from angular
     this.getConfig = getConfig;
 
-    this.shortDotsEnable = this.getConfig('shortDots:enable');
+    this.shortDotsEnable = this.getConfig(SHORT_DOTS_ENABLE_SETTINGS);
     this.metaFields = this.getConfig(META_FIELDS_SETTING);
 
     this.createFieldList = getIndexPatternFieldListCreator({

src/plugins/data/public/query/filter_manager/filter_manager.test.ts

@@ -24,14 +24,14 @@ import { Subscription } from 'rxjs';
 import { FilterManager } from './filter_manager';
 import { getFilter } from './test_helpers/get_stub_filter';
 import { getFiltersArray } from './test_helpers/get_filters_array';
-import { Filter, FilterStateStore } from '../../../common';
+import { Filter, FilterStateStore, FILTERS_PINNED_BY_DEFAULT_SETTINGS } from '../../../common';
 
 import { coreMock } from '../../../../../core/public/mocks';
 const setupMock = coreMock.createSetup();
 
 const uiSettingsMock = (pinnedByDefault: boolean) => (key: string) => {
   switch (key) {
-    case 'filters:pinnedByDefault':
+    case FILTERS_PINNED_BY_DEFAULT_SETTINGS:
       return pinnedByDefault;
     default:
       throw new Error(`Unexpected uiSettings key in FilterManager mock: ${key}`);