[7.x] [uiSettings]: Migrate items owned by app arch to new platform (#66040)#68354
Merged
alexwizp merged 1 commit intoelastic:7.xfrom Jun 5, 2020
Merged
[7.x] [uiSettings]: Migrate items owned by app arch to new platform (#66040)#68354alexwizp merged 1 commit intoelastic:7.xfrom
alexwizp merged 1 commit intoelastic:7.xfrom
Conversation
…c#66040) * Migrated uiSettings items to new platform * API changes * Fixed translations * Fixed comment and i18n * Fixed tests * Fixed internalization * Fix karma tests * made code more explicit * Fixed plugin * Added consts for ui settings ids. * Added id for another settings * Fixed tests. * Improved imports * Fix imports to public which were happening from the server. * Fixed paths * Moved styles to plugin.ts * Moved styles * Fixed docs * Fix ci * Fix ci * fix documentation Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> # Conflicts: # src/legacy/core_plugins/kibana/server/ui_setting_defaults.js
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: