Removes noreferrer on explicit elastic.co domains#31008
Merged
joelgriffith merged 4 commits intoelastic:masterfrom Feb 14, 2019
joelgriffith:chore-remove-noreferrer-for-elasticco
Merged
Removes noreferrer on explicit elastic.co domains#31008joelgriffith merged 4 commits intoelastic:masterfrom joelgriffith:chore-remove-noreferrer-for-elasticco
joelgriffith merged 4 commits intoelastic:masterfrom
joelgriffith:chore-remove-noreferrer-for-elasticco
Conversation
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
peteharverson
approved these changes
Feb 14, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
ML file edits LGTM
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
ogupte
approved these changes
Feb 14, 2019
Contributor
Author
|
6.7 backport: #31326 |
Contributor
Author
|
7.0 backport: #31327 |
joelgriffith
added a commit
that referenced
this pull request
Feb 16, 2019
joelgriffith
added a commit
that referenced
this pull request
Feb 16, 2019
Contributor
|
@ogupte @peteharverson @epixa could you please check this PR, looks like it wasn't backported into 7.x. Partially it will be fixed when we make a backport of #66040 into 7.x but we fix that only for one file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This remove the
noreferrerattribute on docsite links that are "known" elastic.co links. Here's the methodology I went through:noreferrerin Kibana.snapin them (snapshots).elastic.cowere whitelisted. I used my best judgement for the "implied" ones, so feel free to say "no" to them!I'm anticipating some test failures, and will follow up accordingly, but wanted to get this out for review prior to investing more time in stability.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.