[QA] Code coverage: unskip tests, collect tests results, exclude bundles from report#64477
Merged
wayneseymour merged 2 commits intoelastic:masterfrom Jun 5, 2020
Merged
Conversation
dmlemeshko
changed the title
dmlemeshko
force-pushed
the
improve-code-coverage-reporting
branch
from
9ad9c79 to
de43ac9
Compare
dmlemeshko
changed the title
wayneseymour
approved these changes
Apr 29, 2020
wayneseymour
approved these changes
Apr 29, 2020
wayneseymour
approved these changes
Apr 29, 2020
dmlemeshko
added
backport:skip
Contributor
Author
|
@elasticmachine merge upstream |
dmlemeshko
force-pushed
the
improve-code-coverage-reporting
branch
from
bfd9254 to
638e94e
Compare
dmlemeshko
commented
May 14, 2020
Contributor
Author
There was a problem hiding this comment.
@wayneseymour maybe you have an idea why it can fail with
17:58:16 ### Merge coverage reports
17:58:16 yarn run v1.22.4
17:58:16 $ /var/lib/jenkins/workspace/elastic+kibana+coverage-ingestion/kibana/node_modules/.bin/nyc report --nycrc-path src/dev/code_coverage/nyc_config/nyc.jest.config.js
17:58:16 ENOENT: no such file or directory, scandir '/var/lib/jenkins/workspace/elastic+kibana+coverage-ingestion/kibana/target/kibana-coverage/jest'
17:58:16 error Command failed with exit code 1.
Contributor
There was a problem hiding this comment.
Maybe we can list the contents of all the paths in question?
Contributor
Author
There was a problem hiding this comment.
The issue was caused by mixed path during sed operation. I put it out of this PR, we anyway need to think about the smart way of replacing path in jsons
Contributor
Author
There was a problem hiding this comment.
it is working fine now
|
@elasticmachine merge upstream |
spalger
approved these changes
May 29, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
I don't see any issues from an operations perspective
Contributor
Author
|
@elasticmachine merge upstream |
dmlemeshko
force-pushed
the
improve-code-coverage-reporting
branch
from
c1b6461 to
2f3261f
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@wayneseymour could you check it? Coverage pipeline passed |
wayneseymour
approved these changes
Jun 5, 2020
wayneseymour
changed the title
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: (57 commits) Add app arch team as owner of datemath package (elastic#66880) [Observability] Landing page for Observability (elastic#67467) [SIEM] Fix timeline buildGlobalQuery (elastic#68320) Optimize saved objects getScopedClient and HTTP API (elastic#68221) [Maps] Fix mb-style interpolate style rule (elastic#68413) update script to always download node (elastic#68421) [SECURITY SOLEIL] Fix selection of event type when no siem index signal created (elastic#68291) [DOCS] Adds note about configuring File Data Visualizer (elastic#68407) [DOCS] Adds link from remote clusters to index patterns (elastic#68406) [QA] slack notify on failure (elastic#68126) upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (elastic#68295) moving to jira to a gold license (elastic#67178) [DOCS] Revises doc on adding data (elastic#68038) [APM] Add ThemeProvider to support dark mode (elastic#68242) Make welcome screen disabling first action in loginIfPrompted (elastic#68238) [QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (elastic#64477) [ML] Functional tests - disable flaky regression and classification creation test [Alerting] change eventLog ILM requests to absolute URLs (elastic#68331) Report page load asset size (elastic#66224) [SIEM][CASE] Change SIEM to Security (elastic#68365) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR has some improvements for code coverage:
runsedfor coverage json files only before merge to speedup processCoverage job to verify changes: https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/777/