Skip to content

Comments

Add app arch team as owner of datemath package [skip ci]#66880

Merged
timroes merged 2 commits intoelastic:masterfrom
timroes:codeowners-datemath
Jun 8, 2020
Merged

Add app arch team as owner of datemath package [skip ci]#66880
timroes merged 2 commits intoelastic:masterfrom
timroes:codeowners-datemath

Conversation

@timroes
Copy link
Contributor

@timroes timroes commented May 18, 2020

Summary

Add the app arch team as codeowners of the @elastic/datemath package.

@timroes timroes added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 18, 2020
@timroes timroes requested a review from ppisljar May 18, 2020 10:54
@timroes
Copy link
Contributor Author

timroes commented Jun 8, 2020

@elasticmachine merge upstream

Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@timroes timroes merged commit 09eaa1c into elastic:master Jun 8, 2020
@timroes timroes deleted the codeowners-datemath branch June 8, 2020 09:37
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master: (57 commits)
  Add app arch team as owner of datemath package (elastic#66880)
  [Observability] Landing page for Observability (elastic#67467)
  [SIEM] Fix timeline buildGlobalQuery (elastic#68320)
  Optimize saved objects getScopedClient and HTTP API (elastic#68221)
  [Maps] Fix mb-style interpolate style rule (elastic#68413)
  update script to always download node (elastic#68421)
  [SECURITY SOLEIL] Fix selection of event type when no siem index signal created (elastic#68291)
  [DOCS] Adds note about configuring File Data Visualizer (elastic#68407)
  [DOCS] Adds link from remote clusters to index patterns (elastic#68406)
  [QA] slack notify on failure (elastic#68126)
  upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (elastic#68295)
  moving to jira to a gold license (elastic#67178)
  [DOCS] Revises doc on adding data (elastic#68038)
  [APM] Add ThemeProvider to support dark mode (elastic#68242)
  Make welcome screen disabling first action in loginIfPrompted (elastic#68238)
  [QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (elastic#64477)
  [ML] Functional tests - disable flaky regression and classification creation test
  [Alerting] change eventLog ILM requests to absolute URLs (elastic#68331)
  Report page load asset size (elastic#66224)
  [SIEM][CASE] Change SIEM to Security (elastic#68365)
  ...
@stacey-gammon
Copy link

Why only 8.0 and not 7.9?

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66880 or prevent reminders by adding the backport:skip label.

@timroes
Copy link
Contributor Author

timroes commented Jun 10, 2020

@stacey-gammon because we're not having CODEOWNER files on any branch except master, so they are not triggering for the backport PRs.

@timroes timroes added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jun 10, 2020
@stacey-gammon
Copy link

Finally realized that when reconciling the backport merge conflicts. 🤦‍♀️ Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants