Skip to content

Comments

[Code Coverage] update script to always download node#68421

Merged
dmlemeshko merged 2 commits intoelastic:masterfrom
dmlemeshko:code-coverage-always-download-node
Jun 5, 2020
Merged

[Code Coverage] update script to always download node#68421
dmlemeshko merged 2 commits intoelastic:masterfrom
dmlemeshko:code-coverage-always-download-node

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Jun 5, 2020

Summary

Recently there was Node update on worker that caused the failure:

16:26:54  Setting up node.js and yarn in /var/lib/jenkins/workspace/elastic+kibana+code-coverage/kibana
16:26:54   -- Running on OS: linux
16:26:54  which: no yarn in (/var/lib/jenkins/.kibana/node/10.21.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin)
16:26:54  src/dev/ci_setup/setup_env.sh: line 111: node: command not found

Adding true as an argument to setup_env.sh to force download node and prevent this problem.

coverage pipeline for this PR: https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/783/

@dmlemeshko dmlemeshko added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// v8.0.0 labels Jun 5, 2020
@dmlemeshko
Copy link
Contributor Author

@elasticmachine merge upstream

@dmlemeshko dmlemeshko requested a review from brianseeders June 5, 2020 19:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review June 5, 2020 21:27
@dmlemeshko dmlemeshko requested a review from a team as a code owner June 5, 2020 21:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@dmlemeshko dmlemeshko merged commit 1f99144 into elastic:master Jun 5, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master: (57 commits)
  Add app arch team as owner of datemath package (elastic#66880)
  [Observability] Landing page for Observability (elastic#67467)
  [SIEM] Fix timeline buildGlobalQuery (elastic#68320)
  Optimize saved objects getScopedClient and HTTP API (elastic#68221)
  [Maps] Fix mb-style interpolate style rule (elastic#68413)
  update script to always download node (elastic#68421)
  [SECURITY SOLEIL] Fix selection of event type when no siem index signal created (elastic#68291)
  [DOCS] Adds note about configuring File Data Visualizer (elastic#68407)
  [DOCS] Adds link from remote clusters to index patterns (elastic#68406)
  [QA] slack notify on failure (elastic#68126)
  upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (elastic#68295)
  moving to jira to a gold license (elastic#67178)
  [DOCS] Revises doc on adding data (elastic#68038)
  [APM] Add ThemeProvider to support dark mode (elastic#68242)
  Make welcome screen disabling first action in loginIfPrompted (elastic#68238)
  [QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (elastic#64477)
  [ML] Functional tests - disable flaky regression and classification creation test
  [Alerting] change eventLog ILM requests to absolute URLs (elastic#68331)
  Report page load asset size (elastic#66224)
  [SIEM][CASE] Change SIEM to Security (elastic#68365)
  ...
@dmlemeshko dmlemeshko deleted the code-coverage-always-download-node branch January 31, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants