Skip to content

[TSVB] Fix std deviation band mode#64413

Merged
sulemanof merged 5 commits intoelastic:masterfrom
sulemanof:fix/std_deviation_band
May 5, 2020
Merged

[TSVB] Fix std deviation band mode#64413
sulemanof merged 5 commits intoelastic:masterfrom
sulemanof:fix/std_deviation_band

Conversation

@sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Apr 24, 2020

Summary

Resolves #63283

Fix Std. Deviation & Overall Std. Deviation band mode by passing down data in appropriate form for elastic charts
(similar was done for percentiles in #60741)

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof requested review from markov00 and timroes April 24, 2020 13:21
@sulemanof sulemanof added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.1 v7.8.0 v8.0.0 labels Apr 24, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 24, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@sulemanof sulemanof marked this pull request as ready for review April 24, 2020 13:22
@sulemanof sulemanof requested a review from a team April 24, 2020 13:22
@sulemanof
Copy link
Contributor Author

sulemanof commented Apr 29, 2020

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

sulemanof commented May 4, 2020

@elasticmachine merge upstream

markov00
markov00 approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Tested locally and STDEV and overall STDEV works fine

@sulemanof
Merge remote-tracking branch 'upstream/master' into fix/std_deviation…
c4d7ac0 
…_band

# Conflicts:
#	src/plugins/vis_type_timeseries/server/lib/vis_data/helpers/index.js
@kibanamachine
Copy link
Contributor

kibanamachine commented May 4, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome with line and bar, works fine. LGTM

@sulemanof sulemanof merged commit cd595ad into elastic:master May 5, 2020
@sulemanof sulemanof deleted the fix/std_deviation_band branch May 5, 2020 11:25
sulemanof added a commit to sulemanof/kibana that referenced this pull request May 5, 2020
@sulemanof @elasticmachine
[TSVB] Fix std deviation band mode (elastic#64413)
63b8c4a 
* Fix std_deviation_bands mode

* Fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sulemanof sulemanof mentioned this pull request May 5, 2020
Merged
sulemanof added a commit that referenced this pull request May 5, 2020
@sulemanof @elasticmachine
[TSVB] Fix std deviation band mode (#64413) (#65245)
89b0cfd 
* Fix std_deviation_bands mode

* Fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 5, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-actions
93eaa01 
* master: (133 commits)
  Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254)
  Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848)
  Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986)
  [SIEM] Removes prebuilt rules number dependency (elastic#65128)
  [Maps] add categorical palettes with 20 and 30 categories (elastic#64701)
  [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724)
  [Uptime] Console errors in case index missing (elastic#65115)
  [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412)
  [test/functional] Tsfy page objects (elastic#64887)
  [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195)
  [Maps] Add global fit to data (elastic#64702)
  Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699)
  [SIEM] [Cases] External service selection per case (elastic#64775)
  [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055)
  [Metrics UI] Remove APM Hard Dependency (elastic#64952)
  [Ingest] Datastream list: add icons and dashboard links (elastic#65048)
  disable plugins. they could access ES via SO repository (elastic#65242)
  Feature fleet enrollment instructions (elastic#65176)
  [SIEM] Adds 'Configure connector' Cypress test (elastic#64807)
  [TSVB] Fix std deviation band mode (elastic#64413)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

@flash1293 flash1293 flash1293 approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees

No one assigned

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.1 v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TSVB] "Bounds Band" mode broken on both Std. Deviation and Overall Std Deviation

5 participants

@sulemanof @elasticmachine @kibanamachine @markov00 @flash1293