Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog#64986
Merged
YulNaumenko merged 8 commits intoelastic:masterfrom May 5, 2020
Conversation
…e capabilities for modal dialog
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
…oc-links # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
pmuellr
approved these changes
May 4, 2020
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
the docLinks code LGTM, and worked in the UI (pointed to master when running dev mode). I noticed some uses of the TS ! suffix which I think can be removed (or could when I reviewed the PR).
I wasn't quite sure why the capabilities stuff was in here though - should that be in a separate PR? I didn't see any issues with it, but not sure what the original problem was.
...iggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx
Outdated
Show resolved
Hide resolved
...riggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx
Outdated
Show resolved
Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/connector_edit_flyout.tsx
Outdated
Show resolved
Hide resolved
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
Outdated
Show resolved
Hide resolved
phillipb
approved these changes
May 4, 2020
Contributor
phillipb
left a comment
phillipb
left a comment
There was a problem hiding this comment.
Metrics changes look good.
…oc-links # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
|
@elasticmachine merge upstream |
mikecote
approved these changes
May 4, 2020
...plugins/triggers_actions_ui/public/application/components/builtin_action_types/pagerduty.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/slack.tsx
Outdated
Show resolved
Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/action_connector_form.tsx
Outdated
Show resolved
Hide resolved
...ggers_actions_ui/public/application/sections/action_connector_form/connector_edit_flyout.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
rylnd
approved these changes
May 5, 2020
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
SIEM Detection changes LGTM ; case changes look simple enough but I'll ping them just to be sure.
stephmilovic
approved these changes
May 5, 2020
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM on the lone SIEM Case file change 👍
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 5, 2020
…e capabilities for modal dialog (elastic#64986) * Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog * Fixed tests * Extended alert context with application capabilities * Fixed due to comments * Fixed typecheck Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx # x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 5, 2020
* master: (133 commits) Cleanup Typescript index pattern field editor / Expression functions for bucket agg (elastic#65254) Removes legacy infra plugin and moves saved objects registration to NP (elastic#64848) Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog (elastic#64986) [SIEM] Removes prebuilt rules number dependency (elastic#65128) [Maps] add categorical palettes with 20 and 30 categories (elastic#64701) [CI] Slack alerts - Elasticsearch snapshot failures (elastic#64724) [Uptime] Console errors in case index missing (elastic#65115) [SIEM][CASE] Dynamic fields mapping based on connector (elastic#64412) [test/functional] Tsfy page objects (elastic#64887) [Maps] [Telemetry] Track geo_point and geo_shape index patterns separately (elastic#65195) [Maps] Add global fit to data (elastic#64702) Visualize: Reload on ui state change and fix ui state for tsvb (elastic#63699) [SIEM] [Cases] External service selection per case (elastic#64775) [Uptime] Set ML anomaly look-back to 2w (from 24h) / Add spinner (elastic#65055) [Metrics UI] Remove APM Hard Dependency (elastic#64952) [Ingest] Datastream list: add icons and dashboard links (elastic#65048) disable plugins. they could access ES via SO repository (elastic#65242) Feature fleet enrollment instructions (elastic#65176) [SIEM] Adds 'Configure connector' Cypress test (elastic#64807) [TSVB] Fix std deviation band mode (elastic#64413) ...
YulNaumenko
added a commit
that referenced
this pull request
May 5, 2020
…e capabilities for modal dialog (#64986) (#65289) * Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog * Fixed tests * Extended alert context with application capabilities * Fixed due to comments * Fixed typecheck Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx # x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 5, 2020
…e capabilities for modal dialog (elastic#64986) * Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog * Fixed tests * Extended alert context with application capabilities * Fixed due to comments * Fixed typecheck Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/components/alerting/inventory/alert_flyout.tsx # x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 6, 2020
…e capabilities for modal dialog (elastic#64986) * Added support for docLinks plugin in Connectors forms and missing save capabilities for modal dialog * Fixed tests * Extended alert context with application capabilities * Fixed due to comments * Fixed typecheck Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #64308