Removes legacy infra plugin and moves saved objects registration to NP

[jasonrhodes]

Closes #57999
Closes #61773

Summary

This PR moves our logs/metrics saved object registration to the new platform and removes the legacy infra plugin as it's no longer needed 🎉 🎉 🎉 .

In doing this, I've also made all 3 of our saved objects importable and exportable.

To test this:

• visit the logs or metrics section to verify that you can modify the settings in each
• visit the metrics explorer and save a view
• visit the metrics inventory and save a view
• navigate to the management section and look in the saved objects list, you should see 3 saved objects saved there that are now all exportable

Outstanding questions

These have been asked in Slack in #kibana-platform, but still need to be addressed:

• The migration guide here: https://github.com/elastic/kibana/blob/master/src/core/MIGRATION_EXAMPLES.md#saved-objects-types
  says there is a value called namespaceAgnostic that used to be isNamespaceAgnostic, but the SavedObjectType TS type I'm using says the field is namespaceType and that it's required. And I don't know what it is or does (I also don't know what hidden is or does, which is another required field, but I guessed on that one)
• I'd also like to understand what all of the "management" and "migration" field options do ... what's the best way to discover these things?
• also, it looks like the SavedObjectsType from src/core/server isn't a generic, so is it not possible to type the mappings?

[weltenwort]

The migration guide here: /src/core/MIGRATION_EXAMPLES.md@master#saved-objects-types
says there is a value called namespaceAgnostic that used to be isNamespaceAgnostic, but the SavedObjectType TS type I'm using says the field is namespaceType and that it's required. And I don't know what it is or does (I also don't know what hidden is or does, which is another required field, but I guessed on that one)

https://github.com/elastic/kibana/blob/dcc4081bd81d080776f019e98232fe743bd226d2/docs/development/core/server/kibana-plugin-core-server.savedobjectstype.md might be able to explain the attributes.

it looks like the SavedObjectsType from src/core/server isn't a generic, so is it not possible to type the mappings?

The type of the value returned from a savedObjectClient is

kibana/src/core/types/saved_objects.ts

Lines 80 to 101 in dcc4081

	export interface SavedObject<T = unknown> {
	/** The ID of this Saved Object, guaranteed to be unique for all objects of the same `type` */
	id: string;
	/** The type of Saved Object. Each plugin can define it's own custom Saved Object types. */
	type: string;
	/** An opaque version number which changes on each successful write operation. Can be used for implementing optimistic concurrency control. */
	version?: string;
	/** Timestamp of the last time this document had been updated. */
	updated_at?: string;
	error?: {
	message: string;
	statusCode: number;
	};
	/** {@inheritdoc SavedObjectAttributes} */
	attributes: T;
	/** {@inheritdoc SavedObjectReference} */
	references: SavedObjectReference[];
	/** {@inheritdoc SavedObjectsMigrationVersion} */
	migrationVersion?: SavedObjectsMigrationVersion;
	/** Namespace(s) that this saved object exists in. This attribute is only used for multi-namespace saved object types. */
	namespaces?: string[];
	}

, which is generic in its attributes.

The SavedObjectType is the declaration used to register a type.

In any case, I would recommend using io-ts to decode anything retrieved from ES via a savedObjectClient as we do for the source configuration. That way it is properly and consistently typed regardless.

[afgomez]

I pulled the code. I couldn't find anything broken 🎉

[afgomez]

@weltenwort I'm so sorry. I just saw that you were reviewing this PR already. For some reason github didn't put your avatar in the reviewers' list and I assigned it to myself.

[jasonrhodes]

@afgomez I think @weltenwort just commented on something, I don't think he assigned himself as a reviewer. Thanks to you both! I'm going to see about adding a decode before I merge anything.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: a3af475

History

• 💚 Build #45253 succeeded 8d479bc
• 💚 Build #44552 succeeded 5b641f4
• 💚 Build #44278 succeeded bdd1951

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream