[TSVB] Fix percentiles band mode#60741
Merged
sulemanof merged 5 commits intoelastic:masterfrom Mar 23, 2020
Merged
Conversation
sulemanof
added
Feature:TSVB
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
markov00
approved these changes
Mar 20, 2020
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM, checked locally and seems to work correctly, band area chart and bar chart shown fine.
I'd like to suggest two small changes to apply that will provide a nice addition:
- the
Fill toinput should be limited to into the domain of 0, 100. More than 100 result in error on the chart that can be avoided if possible
- the legend is correctly showing the upper and lower bound of the area, but we have a set of props on the
AreaSeries,BarSeriescomponents that allows you to fix the legend items into two nicer legend items.
The current visualization shows:
Instead you can configure the series name without the (50) value and add the values of the upper and lower bound in the following props:
y1AccessorFormat=" (50)"
y0AccessorFormat=" (10)"
like
see https://elastic.github.io/elastic-charts/?path=/story/area-chart--band-area&knob-scale to extent=true&knob-y0AccessorFormat= (50)&knob-y1AccessorFormat= (10) for an example
Contributor
Author
|
Hey @markov00 !
Thanks for suggestions, I updated the PR due to recommendations! |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 23, 2020
* Fix percentiles band mode * Add support of bar chart, fix tests * Use accessor formatters * Fix tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (26 commits) [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893) cleanup visualizations api (elastic#59958) Inline timezoneProvider function, remove ui/vis/lib/timezone (elastic#60475) [SIEM] Adds 'Open one signal' Cypress test (elastic#60484) [UA] Upgrade assistant migration meta data can become stale (elastic#60789) [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679) [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741) Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779) [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) ...
sulemanof
added a commit
that referenced
this pull request
Mar 24, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #58840
Fixes #34943
Make TSVB supports
Bandmode withPercentilemetric:This also adds support of
barchart type inBandmode (was not presented in earlier versions):Checklist
Delete any items that are not applicable to this PR.
For maintainers