[APM] service maps: avoid unnecesary useDeepObjectIdentity#60836
Merged
sorenlouv merged 2 commits intoelastic:masterfrom Mar 21, 2020
Merged
[APM] service maps: avoid unnecesary useDeepObjectIdentity#60836sorenlouv merged 2 commits intoelastic:masterfrom
useDeepObjectIdentity#60836sorenlouv merged 2 commits intoelastic:masterfrom
Conversation
dgieselaar
approved these changes
Mar 21, 2020
Contributor
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
Thanks - I think I forgot this when removing the pagination. Did you figure out how exactly environment works for the service map queries?
Member
Author
I didn't look into that yet. Just wanted to get this minor thing out of the way. |
sorenlouv
added
release_note:skip
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
sorenlouv
added a commit
that referenced
this pull request
Mar 21, 2020
…#60861) * [APM] service maps: avoid unnecesary `useDeepObjectIdentity` * Remove unused dep
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (39 commits) [APM]Create custom link from Trace summary (elastic#59648) [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734) [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016) Skip failing test [Uptime]Update fetch effect failed action handling (elastic#60742) [npm] upgrade elastic/maki (elastic#60829) [Uptime] Add Settings Page (elastic#53550) [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836) [Index management] Re-enable index template tests (elastic#60780) Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703) [SIEM] Fix patching of ML Rules (elastic#60830) [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477) [Alerting] fix flaky test for index threshold grouping (elastic#60792) [SIEM][Detection Engine] Adds test scripts for machine learning feature Flatten child api response for resolver (elastic#60810) Change "url" to "urls" in APM agent instructions (elastic#60790) [DOCS] Updates API requests and examples (elastic#60695) [SIEM] [Cases] Create case from timeline (elastic#60711) [Lens] Resetting a layer generates new suggestions (elastic#60674) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvement to service maps data fetching