Flatten child api response for resolver#60810
Merged
kqualters-elastic merged 1 commit intoelastic:masterfrom Mar 20, 2020
Merged
Flatten child api response for resolver#60810kqualters-elastic merged 1 commit intoelastic:masterfrom
kqualters-elastic merged 1 commit intoelastic:masterfrom
Conversation
dplumlee
approved these changes
Mar 20, 2020
kqualters-elastic
added
Feature:Endpoint
Contributor
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
james-elastic
approved these changes
Mar 20, 2020
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (39 commits) [APM]Create custom link from Trace summary (elastic#59648) [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734) [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016) Skip failing test [Uptime]Update fetch effect failed action handling (elastic#60742) [npm] upgrade elastic/maki (elastic#60829) [Uptime] Add Settings Page (elastic#53550) [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836) [Index management] Re-enable index template tests (elastic#60780) Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703) [SIEM] Fix patching of ML Rules (elastic#60830) [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477) [Alerting] fix flaky test for index threshold grouping (elastic#60792) [SIEM][Detection Engine] Adds test scripts for machine learning feature Flatten child api response for resolver (elastic#60810) Change "url" to "urls" in APM agent instructions (elastic#60790) [DOCS] Updates API requests and examples (elastic#60695) [SIEM] [Cases] Create case from timeline (elastic#60711) [Lens] Resetting a layer generates new suggestions (elastic#60674) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kqualters-elastic
added a commit
to kqualters-elastic/kibana
that referenced
this pull request
Mar 24, 2020
kqualters-elastic
added a commit
that referenced
this pull request
Mar 24, 2020
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The resolver middleware was expecting the children api to be an array of events, but it was actually a 2d array of events. This flattens it so that resolver displays children as it should.
