[APM]Create custom link from Trace summary#59648
Merged
cauemarcondes merged 26 commits intoelastic:masterfrom Mar 23, 2020
Merged
[APM]Create custom link from Trace summary#59648cauemarcondes merged 26 commits intoelastic:masterfrom
cauemarcondes merged 26 commits intoelastic:masterfrom
Conversation
1db124d to
921d7e6
Compare
sorenlouv
reviewed
Mar 10, 2020
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 10, 2020
...k/legacy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/LicensePrompt.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 11, 2020
x-pack/plugins/apm/server/lib/settings/custom_link/create_custom_link_index.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 11, 2020
...plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/helper.ts
Outdated
Show resolved
Hide resolved
ff13d7a to
7729021
Compare
streamich
reviewed
Mar 16, 2020
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
7cadbd8 to
8d4ad08
Compare
formgeist
approved these changes
Mar 17, 2020
Contributor
formgeist
left a comment
There was a problem hiding this comment.
just minor visual nits on the popover
.../plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkPopover.tsx
Outdated
Show resolved
Hide resolved
.../plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkPopover.tsx
Outdated
Show resolved
Hide resolved
...y/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/ManageCustomLink.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 17, 2020
...ugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/CustomLink.test.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 17, 2020
...cy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/helper.test.ts
Outdated
Show resolved
Hide resolved
smith
approved these changes
Mar 17, 2020
...ugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/CustomLink.test.tsx
Outdated
Show resolved
Hide resolved
...cy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/helper.test.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 18, 2020
x-pack/legacy/plugins/apm/public/components/shared/LicensePrompt/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
retest |
Contributor
|
@cauemarcondes spotted the CI error from the ML job cloning test on this PR. If you haven't done so already, you probably want to rebase against master as we disabled this test yesterday whilst we work on a stability fix for the failing test. |
Contributor
Author
Thanks @peteharverson will do it. |
db206d1 to
a628b31
Compare
sorenlouv
reviewed
Mar 19, 2020
x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 19, 2020
x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 19, 2020
sorenlouv
reviewed
Mar 19, 2020
x-pack/plugins/apm/server/lib/settings/custom_link/create_custom_link_index.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 19, 2020
72acd05 to
6c9c8fc
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_listing·js.dashboard app using legacy data dashboard listing page search does not match mid wordStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (39 commits) [APM]Create custom link from Trace summary (elastic#59648) [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734) [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016) Skip failing test [Uptime]Update fetch effect failed action handling (elastic#60742) [npm] upgrade elastic/maki (elastic#60829) [Uptime] Add Settings Page (elastic#53550) [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836) [Index management] Re-enable index template tests (elastic#60780) Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703) [SIEM] Fix patching of ML Rules (elastic#60830) [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477) [Alerting] fix flaky test for index threshold grouping (elastic#60792) [SIEM][Detection Engine] Adds test scripts for machine learning feature Flatten child api response for resolver (elastic#60810) Change "url" to "urls" in APM agent instructions (elastic#60790) [DOCS] Updates API requests and examples (elastic#60695) [SIEM] [Cases] Create case from timeline (elastic#60711) [Lens] Resetting a layer generates new suggestions (elastic#60674) ...
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Mar 23, 2020
* adding custom links to actions menu * user should have at least gold license to be able to manage custom links * replacing variable for the correspondent value * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * adding unit test, splitting value by comma and removing empty ones * adding custom links to actions menu * UI fixes * moving stuff to common * changing flyout texts * refactoring getSelectOption * refactoring getSelectOption * refactoring filter options name * adding preview panel * adding preview panel * fixing test * adding unit test for replace template variables * fixing typo * polishing preview panel * fixing pr comments * fixing pr comments * adding links * fixing unit test * removing servicemap license prompt
cauemarcondes
added a commit
that referenced
this pull request
Mar 23, 2020
* adding custom links to actions menu * user should have at least gold license to be able to manage custom links * replacing variable for the correspondent value * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * adding unit test, splitting value by comma and removing empty ones * adding custom links to actions menu * UI fixes * moving stuff to common * changing flyout texts * refactoring getSelectOption * refactoring getSelectOption * refactoring filter options name * adding preview panel * adding preview panel * fixing test * adding unit test for replace template variables * fixing typo * polishing preview panel * fixing pr comments * fixing pr comments * adding links * fixing unit test * removing servicemap license prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #57783
closes #58923
closes #59780
closes #58110
Show custom links in the Actions menu, with a
createandmanagebuttons. The first three links will be shown in the first popover and the remaining after the user pushes theSee morebutton.