[DOCS] Updates API requests and examples#60695
Merged
KOTungseth merged 3 commits intoelastic:masterfrom Mar 20, 2020
Merged
Conversation
KOTungseth
added
Team:Docs
release_note:skip
Contributor
|
Pinging @elastic/kibana-docs (Team:Docs) |
joshdover
approved these changes
Mar 19, 2020
Contributor
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
LGTM, just a couple suggestions
| ==== Request | ||
|
|
||
| `GET /api/kibana/dashboards/export` | ||
| `GET <kibana host>:port/api/kibana/dashboards/export` |
Contributor
There was a problem hiding this comment.
Should port also be in angle brackets?
Suggested change
| `GET <kibana host>:port/api/kibana/dashboards/export` | |
| `GET <kibana host>:<port>/api/kibana/dashboards/export` |
If so, the rest will need to be changed as well.
| @@ -35,8 +35,8 @@ experimental[] Export dashboards and corresponding saved objects. | |||
|
|
|||
| [source,js] | |||
Contributor
There was a problem hiding this comment.
is there a console or sh type for syntax highlighting?
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Mar 20, 2020
* [DOCS] Updates API requests and examples * Review comments
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Mar 20, 2020
* [DOCS] Updates API requests and examples * Review comments
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (39 commits) [APM]Create custom link from Trace summary (elastic#59648) [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734) [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016) Skip failing test [Uptime]Update fetch effect failed action handling (elastic#60742) [npm] upgrade elastic/maki (elastic#60829) [Uptime] Add Settings Page (elastic#53550) [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836) [Index management] Re-enable index template tests (elastic#60780) Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703) [SIEM] Fix patching of ML Rules (elastic#60830) [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477) [Alerting] fix flaky test for index threshold grouping (elastic#60792) [SIEM][Detection Engine] Adds test scripts for machine learning feature Flatten child api response for resolver (elastic#60810) Change "url" to "urls" in APM agent instructions (elastic#60790) [DOCS] Updates API requests and examples (elastic#60695) [SIEM] [Cases] Create case from timeline (elastic#60711) [Lens] Resetting a layer generates new suggestions (elastic#60674) ...
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
KOTungseth
added a commit
that referenced
this pull request
Mar 26, 2020
KOTungseth
added a commit
that referenced
this pull request
Mar 26, 2020
kibanamachine
removed
the
backport missing
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Apr 17, 2020
* [DOCS] Updates API requests and examples * Review comments
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Apr 17, 2020
* [DOCS] Updates API requests and examples * Review comments
KOTungseth
added a commit
that referenced
this pull request
Apr 17, 2020
KOTungseth
added a commit
that referenced
this pull request
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<kibana host>:<port>/api/etcto all requests$ curl -X POST "localhost:5601/api/Checklist