Goodbye, legacy data plugin 👋

[lukeelmers]

Well. It's been real. It's been fun. But it hasn't been real fun. 😉

With #59044 recently merging, there is no longer any code left in the legacy data "shim" plugin: src/legacy/core_plugins/data. This PR officially removes the remaining boilerplate, as well as a few references to it that were lingering around the repo.

Moving forward, folks can find everything they need in the new platform plugin: src/plugins/data

Dev docs

The legacy data plugin located in src/legacy/core_plugins/data has been removed. This change only affects legacy platform plugins which are either:

1. Importing the public/setup or public/legacy "shim" files from the legacy data plugin to access runtime contracts; or
2. importing static code from inside src/legacy/core_plugins/data; or
3. explicitly using require: ['data'] in the plugin definition.

For scenario 1 above, you should migrate your plugin to access the services you need from the new platform data plugin. These are accessible in the legacy world by using ui/new_platform:

- import { start as dataStart } from 'src/legacy/core_plugins/data/public/legacy';
+ import { npStart } from 'ui/new_platform';
+ const dataStart = npStart.plugins.data;

For scenario 2, the equivalent static code you've been importing should now be available from src/plugins/data, in the server or public directories:

- import { someStaticUtilOrType } from 'src/legacy/core_plugins/data/public';
+ import { someStaticUtilOrType } from 'src/plugins/data/public';

For scenario 3, you should be able to safely drop the reference to the plugin, and add data to your list of dependencies in kibana.json whenever your plugin migrates to the new Kibana platform:

// index.ts
const myPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) =>
  new Plugin({
    id: 'my_plugin',
-    require: ['kibana', 'elasticsearch', 'visualizations', 'data'],
+    require: ['kibana', 'elasticsearch', 'visualizations'],
    ...,
  })
);

For more information on where to locate new platform data services, please refer to the table of plugins for shared application services in src/core/MIGRATION.md.

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[kertal]

KibanaApp files LGTM, goodbye data plugin, it was a pleasure 😢 . Chrome also want's to say: bye

[lizozom]

LGTM!!!

[lizozom]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4850bb5

History

• 💚 Build #34203 succeeded c54e239
• 💔 Build #34009 failed 19e53bbd64716833d2f84694ffe2069de3c45e25

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream