Skip to content

Inline timezoneProvider function, remove ui/vis/lib/timezone #60475

Merged
kertal merged 5 commits intoelastic:masterfrom
kertal:kertal-pr-2020-03-17-inline-timezoneProvider
Mar 23, 2020
Merged

Inline timezoneProvider function, remove ui/vis/lib/timezone #60475
kertal merged 5 commits intoelastic:masterfrom
kertal:kertal-pr-2020-03-17-inline-timezoneProvider

Conversation

@kertal
Copy link
Member

@kertal kertal commented Mar 18, 2020

Summary

Inline timezoneProvider function where it's needed (discover, timelion, TSVB), removing ui/vis/lib/timezone

Part of #60098

@kertal kertal self-assigned this Mar 18, 2020
@flash1293 flash1293 mentioned this pull request Mar 18, 2020
8 tasks
@thomasneirynck thomasneirynck added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal changed the title [WIP] Inline timezoneProvider function Inline timezoneProvider function, remove ui/vis/lib/timezone Mar 19, 2020
@kertal kertal marked this pull request as ready for review March 19, 2020 16:38
@kertal kertal requested review from a team and sulemanof March 19, 2020 16:38
@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Mar 20, 2020
@flash1293 flash1293 mentioned this pull request Mar 23, 2020
69 tasks
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGMT (once green) 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit c537d45 into elastic:master Mar 23, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
* master: (26 commits)
  [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893)
  cleanup visualizations api (elastic#59958)
  Inline timezoneProvider function, remove ui/vis/lib/timezone  (elastic#60475)
  [SIEM] Adds 'Open one signal' Cypress test (elastic#60484)
  [UA] Upgrade assistant migration meta data can become stale (elastic#60789)
  [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679)
  [Uptime] Skip failing location test temporarily (elastic#60938)
  [ML] Disabling datafeed editing when job is running (elastic#60751)
  Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717)
  [SIEM] Add license check to ML Rule form (elastic#60691)
  Adding `authc.grantAPIKeyAsInternalUser`  (elastic#60423)
  Support Histogram Data Type (elastic#59387)
  [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770)
  [SIEM] [Cases] Update case icons (elastic#60812)
  [TSVB] Fix percentiles band mode (elastic#60741)
  Fix formatter on range aggregation (elastic#58651)
  Goodbye, legacy data plugin 👋 (elastic#60449)
  [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779)
  [Remote clustersadopt changes to remote info API (elastic#60795)
  Only run xpack siem cypress in PRs when there are siem changes (elastic#60661)
  ...
kertal added a commit to kertal/kibana that referenced this pull request Mar 23, 2020
…#60475)

* Inline getTimezone in discover, vis_type_timeseries,  timelion app & vis_type_timelion
kertal added a commit that referenced this pull request Mar 24, 2020
…#60966)

* Inline getTimezone in discover, vis_type_timeseries,  timelion app & vis_type_timelion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants