Change remote_clusters ID to remoteClusters#59246
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Mar 5, 2020
Merged
Conversation
cjcenizal
added
chore
Feature:CCR and Remote Clusters
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Mar 4, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cjcenizal code LGTM. Did not test locally. I actually had this on my list to do tomorrow, so thanks for taking care of it 😄
joshdover
approved these changes
Mar 4, 2020
Contributor
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
NP changes LGTM, you might want to also change the legacy ID to make them consistent: x-pack/legacy/plugins/remote_clusters/common/index.ts
I'm not aware of anything that would break, but just to be sure.
…me for license check.
cjcenizal
force-pushed
the
chore/camelcase_remote_clusters_id
branch
from
11c5826 to
f84b9a7
Compare
cjcenizal
force-pushed
the
chore/camelcase_remote_clusters_id
branch
from
f84b9a7 to
58a0fc3
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cjcenizal
commented
Mar 5, 2020
| configPrefix: 'xpack.ccr', | ||
| publicDir: resolve(__dirname, 'public'), | ||
| require: ['kibana', 'elasticsearch', 'xpack_main', 'remote_clusters', 'index_management'], | ||
| require: ['kibana', 'elasticsearch', 'xpack_main', 'remoteClusters', 'index_management'], |
Contributor
Author
There was a problem hiding this comment.
@joshdover Do you know how this require config option works?
Contributor
There was a problem hiding this comment.
Ah just saw this. In legacy it causes Kibana to crash if an enabled plugin depends on a plugin that is not enabled. I believe it only looks at other legacy plugins.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 5, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (254 commits) Convert discover_page to ts, remove redundunt methods (elastic#59312) [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873) Delete legacy search endpoint (elastic#59341) [Uptime] Improve duration chart (elastic#58404) [Snapshot & Restore] NP migration (elastic#59109) [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017) Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)" Change remote_clusters ID to remoteClusters (elastic#59246) Makes alerting and actions optional properties for interface RequestH… (elastic#59264) Clean up date histogram agg type. (elastic#58805) [ML] Management: fix license unsubscribe (elastic#59365) Remove documentation for server.cors settings (elastic#59096) Edit alert flyout (elastic#58964) [SIEM] Fix rule delete/duplicate actions (elastic#59306) move mouse to close obstructing tooltip (elastic#59214) Reset page after deleting (elastic#59310) Make sure phrases input filter triggers autosuggestons (elastic#59299) Add loading count source for http requests (elastic#59245) Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)" Expose metrics service to public API (elastic#59294) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
cjcenizal
added a commit
that referenced
this pull request
Mar 6, 2020
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59183
Also, use human readable name for license check.