[ML] Add support for date_nanos time field in anomaly job wizard#59017
Merged
peteharverson merged 3 commits intoelastic:masterfrom Mar 5, 2020
Merged
[ML] Add support for date_nanos time field in anomaly job wizard#59017peteharverson merged 3 commits intoelastic:masterfrom
peteharverson merged 3 commits intoelastic:masterfrom
Conversation
peteharverson
added
release_note:enhancement
review
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
approved these changes
Mar 2, 2020
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added a couple of comments, but generally LGTM
x-pack/plugins/ml/server/models/job_validation/validate_time_range.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/job_validation/validate_time_range.ts
Outdated
Show resolved
Hide resolved
peteharverson
force-pushed
the
ml-validate-date-nanos
branch
from
b92491b to
00ce82f
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
that referenced
this pull request
Mar 5, 2020
) (#59403) * [ML] Add support for date_nanos time field in anomaly job wizard * [ML] Edits following review * [ML] Add functional test for creating job off date_nanos data
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 5, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (254 commits) Convert discover_page to ts, remove redundunt methods (elastic#59312) [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873) Delete legacy search endpoint (elastic#59341) [Uptime] Improve duration chart (elastic#58404) [Snapshot & Restore] NP migration (elastic#59109) [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017) Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)" Change remote_clusters ID to remoteClusters (elastic#59246) Makes alerting and actions optional properties for interface RequestH… (elastic#59264) Clean up date histogram agg type. (elastic#58805) [ML] Management: fix license unsubscribe (elastic#59365) Remove documentation for server.cors settings (elastic#59096) Edit alert flyout (elastic#58964) [SIEM] Fix rule delete/duplicate actions (elastic#59306) move mouse to close obstructing tooltip (elastic#59214) Reset page after deleting (elastic#59310) Make sure phrases input filter triggers autosuggestons (elastic#59299) Add loading count source for http requests (elastic#59245) Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)" Expose metrics service to public API (elastic#59294) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the creation of an anomaly detection job off an index pattern which has a time field of type
date_nanos. Previously the job validation checks only allowed the use of a time field of typedate.Part of #53609.
Checklist
Fixes #52921