[Fix for Vis Editor] Revert setting time field to empty string when it's undefined#58873
Merged
maryia-lapata merged 7 commits intoelastic:masterfrom Mar 5, 2020
Merged
Conversation
maryia-lapata
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
maryia-lapata
requested review from
flash1293 and
mattkime
and removed request for
mattkime
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
lizozom
reviewed
Mar 4, 2020
Contributor
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Bug is resolved, but can we add a test to cover this case?
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
maryia-lapata
added a commit
that referenced
this pull request
Mar 5, 2020
…t's undefined (#58873) (#59407) * Revert setting time field to empty string when it's undefined * Add unit test * Mock timeFields * Update step_time_field.test.tsx Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 5, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (254 commits) Convert discover_page to ts, remove redundunt methods (elastic#59312) [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873) Delete legacy search endpoint (elastic#59341) [Uptime] Improve duration chart (elastic#58404) [Snapshot & Restore] NP migration (elastic#59109) [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017) Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)" Change remote_clusters ID to remoteClusters (elastic#59246) Makes alerting and actions optional properties for interface RequestH… (elastic#59264) Clean up date histogram agg type. (elastic#58805) [ML] Management: fix license unsubscribe (elastic#59365) Remove documentation for server.cors settings (elastic#59096) Edit alert flyout (elastic#58964) [SIEM] Fix rule delete/duplicate actions (elastic#59306) move mouse to close obstructing tooltip (elastic#59214) Reset page after deleting (elastic#59310) Make sure phrases input filter triggers autosuggestons (elastic#59299) Add loading count source for http requests (elastic#59245) Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)" Expose metrics service to public API (elastic#59294) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58862.
The issue is if a date histogram aggregation is configured in the vis based on an index pattern without a time filter, errors are logged into the console and the page is empty.
Steps to reproduce:
The reason is that when an index pattern is created with
I don't want to use the Time Filtertime filter option, theselectedTimeFieldis set as an empty string instead ofundefineddue to recent changes in #56987. And inagg_config.tshttps://github.com/mattkime/kibana/blob/0adfdcafe137692750118277927f9a3ccbf26faa/src/legacy/core_plugins/data/public/search/aggs/agg_config.ts#L190-L191
valis""andval == nulis false, which leads to callingdeserializefunction when it shouldn't.