Skip to content

move mouse to close obstructing tooltip#59214

Merged
LeeDr merged 2 commits intoelastic:masterfrom
LeeDr:fixDiscoverTooltip
Mar 4, 2020
Merged

move mouse to close obstructing tooltip#59214
LeeDr merged 2 commits intoelastic:masterfrom
LeeDr:fixDiscoverTooltip

Conversation

@LeeDr
Copy link

@LeeDr LeeDr commented Mar 3, 2020

Summary

This is another PR to fix a test "visualize app visualize lab mode disabling does not break loading saved searches" which passes HEADLESS (like in Jenkins) but fails reliably for me when run locally with a visible browser. The problem in this case is a tooltip obstructing the use of the Discover Open menu item.

image

The fix, only implemented on the one discover_page method that is breaking this test, is to move the mouse to that menu item before clicking it.

The failure looks like this;

[21:00:34.869752235] visualize lab mode
[21:00:34.870782136] disabling does not break loading saved searches:
[21:00:34.872048252] retry.try timeout: Error: retry.try timeout: ElementClickInterceptedError: element click intercepted: Element <button class="euiButtonEmpty euiButtonEmpty--primary euiButtonEmpty--xSmall" type="button" data-test-subj="discoverOpenButton">...</button> is not clickable at point (171, 69). Other element would receive the click: <div>...</div>

Checklist

Delete any items that are not applicable to this PR.

@LeeDr LeeDr added test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@LeeDr
Copy link
Author

LeeDr commented Mar 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

}

async clickLoadSavedSearchButton() {
await testSubjects.moveMouseTo('discoverOpenButton');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have this internally but looks like it was commented out:

Screen Shot 2020-03-04 at 10 06 03 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented it out during Leadfoot -> Webdriver migration, since many tests were failing on moveMouseTo.
The plan was to find a reason for that issue, but the easiest way was to keep it commented out.
Now I think we need to remove it to avoid confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw people adding moveMouseTo in some test/method explicitly and it looks reasonable and easy to follow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stacey-gammon would you like me to remove the commented out moveMouseTo line in this PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you, just was pointing it out, changes LGTM!

Copy link
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr LeeDr merged commit 754e6f1 into elastic:master Mar 4, 2020
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Mar 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
LeeDr pushed a commit that referenced this pull request Mar 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@LeeDr LeeDr deleted the fixDiscoverTooltip branch March 4, 2020 22:09
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 5, 2020
…re/files-and-filetree

* 'master' of github.com:elastic/kibana: (254 commits)
  Convert discover_page to ts, remove redundunt methods (elastic#59312)
  [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873)
  Delete legacy search endpoint (elastic#59341)
  [Uptime] Improve duration chart (elastic#58404)
  [Snapshot & Restore] NP migration (elastic#59109)
  [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017)
  Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)"
  Change remote_clusters ID to remoteClusters (elastic#59246)
  Makes alerting and actions optional properties for interface RequestH… (elastic#59264)
  Clean up date histogram agg type. (elastic#58805)
  [ML] Management: fix license unsubscribe (elastic#59365)
  Remove documentation for server.cors settings (elastic#59096)
  Edit alert flyout (elastic#58964)
  [SIEM] Fix rule delete/duplicate actions (elastic#59306)
  move mouse to close obstructing tooltip (elastic#59214)
  Reset page after deleting (elastic#59310)
  Make sure phrases input filter triggers autosuggestons (elastic#59299)
  Add loading count source for http requests (elastic#59245)
  Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)"
  Expose metrics service to public API (elastic#59294)
  ...

# Conflicts:
#	src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// test_ui_functional v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments