rebalance x-pack groups by LeeDr · Pull Request #58930 · elastic/kibana

LeeDr · 2020-02-28T19:36:04Z

Summary

The long-pole job xpack-kibana-ciGroup3 - (1 hr 17 min in self) was adding about 30 minutes to all Kibana ci jobs. I moved things around to even them out. With this change the longest job should be xpack-kibana-ciGroup6 - (48 min in self).

We might be able to reduce that 48 a couple of minutes, but the average is almost 42 minutes so there's not much improvement to be made without adding another ciGroup.

Execute kibana-ciGroup1 - (18 min in self)			Console Output	Success
Execute kibana-ciGroup2 - (8 min 17 sec in self)		Console Output	Success
Execute kibana-ciGroup3 - (18 min in self)			Console Output	Success
Execute kibana-ciGroup4 - (15 min in self)			Console Output	Success
Execute kibana-ciGroup5 - (12 min in self)			Console Output	Success
Execute kibana-ciGroup6 - (22 min in self)			Console Output	Success
Execute kibana-ciGroup7 - (16 min in self)			Console Output	Success
Execute kibana-ciGroup8 - (13 min in self)			Console Output	Success
Execute kibana-ciGroup9 - (16 min in self)			Console Output	Success
Execute kibana-ciGroup10 - (15 min in self)			Console Output	Success
Execute kibana-ciGroup11 - (17 min in self)			Console Output	Success
Execute kibana-ciGroup12 - (19 min in self)			Console Output	Success
Branch: oss-accessibility - (11 min in block)				Success

Execute xpack-kibana-ciGroup1 - (40 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup2 - (45 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup3 - (1 hr 17 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup4 - (45 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup5 - (30 min in self)			Console Output	Success - 
Execute xpack-kibana-ciGroup6 - (48 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup7 - (38 min in self)			Console Output	Success 40
Execute xpack-kibana-ciGroup8 - (33 min in self)			Console Output	Success 39.5
Execute xpack-kibana-ciGroup9 - (31 min in self)			Console Output	Success 40.5
Execute xpack-kibana-ciGroup10 - (30 min in self)			Console Output	Success - 38


(these are just my notes from Jenkins to see how long various tests ran)

x-pack/test/functional/apps/dashboard/index.ts:    this.tags('ciGroup3'); 2 minutes > group 7 ~40
00:38:24.380         └-: dashboard

x-pack/test/functional/apps/discover/index.ts:    this.tags('ciGroup3'); 6.5 minutes > group 8 ~39.5
00:40:16.717         └-: discover

x-pack/test/functional/apps/machine_learning/index.ts:    this.tags('ciGroup3'); 37 minutes
00:46:45.501         └-: machine learning

x-pack/test/functional/apps/dev_tools/index.ts:    this.tags('ciGroup3'); 4 minutes > group 10
01:23:40.574         └-: console 

x-pack/test/functional/apps/index_management/index.ts:    this.tags('ciGroup3');  1 minute
01:27:39.968         └-: Index Management app

01:27:50.669       │685 passing (49.0m)
01:27:50.669       │30 pending


x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/index.ts:    this.tags('ciGroup3');
01:28:54.984         └-: Actions and Triggers app                       4 minutes group 10
01:32:46.503       │21 passing (3.0m)
01:32:46.503       │13 pending

x-pack/test/alerting_api_integration/spaces_only/tests/index.ts:    this.tags('ciGroup3');
01:33:51.546         └-: alerting api integration spaces only           4 minutes  > group 9
01:37:08.003       │58 passing (3.0m)

x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts:    this.tags('ciGroup3');
01:38:12.479         └-: alerting api integration security and spaces enabled 4.5 minutes group 9
01:52:57.892       │454 passing (14.0m)

mikecote

Alerting changes LGTM!

LeeDr · 2020-02-29T00:42:16Z

@elasticmachine merge upstream

LeeDr · 2020-02-29T00:43:55Z

The last job failed on some x-pack Jest tests, but here's the timing of the functional tests;
What I'm seeing is that the times vary quite a bit from one run to the next even with no changes in the ciGroup.

Execute xpack-kibana-ciGroup1 - (40 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup2 - (47 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup3 - (42 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup4 - (46 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup5 - (47 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup6 - (50 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup7 - (41 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup8 - (42 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup9 - (37 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup10 - (41 min in self)			Console Output	Success
Branch: xpack-accessibility - (8 min 0 sec in block)				Success

LeeDr · 2020-03-02T17:04:30Z

@elasticmachine merge upstream

LeeDr · 2020-03-02T21:59:31Z

@elasticmachine merge upstream

brianseeders · 2020-03-03T16:19:55Z

Interesting, I've been seeing that ERROR UnexpectedAlertOpenError: unexpected alert open: {Alert text : } on a branch I have open that also re-arranges the order that tests are run in

LeeDr · 2020-03-03T21:53:22Z

@elasticmachine merge upstream

LeeDr · 2020-03-04T15:01:29Z

@elasticmachine merge upstream

LeeDr · 2020-03-04T21:00:52Z

Seems like this PR needs this fix #59329

* Add custom action to registry and show actions list in siem * Exposed action form as reusable component * Fixed few small bugs * Fixed red ci * Fixed type checks * Fixed failed tests * Fixed due to comments * Fixed type check errors * Fixed plugin check * Rebalancing CI groups according to #58930 * Fixed merge issues

LeeDr · 2020-03-11T17:23:05Z

@elasticmachine merge upstream

spalger · 2020-03-11T19:12:31Z

@elasticmachine merge upstream

spalger · 2020-03-11T21:47:14Z

@elasticmachine merge upstream

kibanamachine · 2020-03-11T23:21:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e0b2b58

History

💚 Build #32554 succeeded 9b7c92d
💔 Build #32505 failed 8bc82cf
💔 Build #32181 failed d29643c
💔 Build #30777 failed 2e853a3
💔 Build #30557 failed c684716

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger

LGTM

* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...

* rebalance x-pack groups * fix typo in ciGroup10 * move from group 9 to group 5 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com>

* rebalance x-pack groups * fix typo in ciGroup10 * move from group 9 to group 5 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com>

rebalance x-pack groups

e772d91

LeeDr added test v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 28, 2020

LeeDr requested a review from a team as a code owner February 28, 2020 19:36

mikecote approved these changes Feb 28, 2020

View reviewed changes

LeeDr requested review from brianseeders and spalger February 28, 2020 20:00

LeeDr added 2 commits February 28, 2020 14:36

fix typo in ciGroup10

c3e5d59

move from group 9 to group 5

de8b9ab

Merge branch 'master' into rebalanceXpackGroups

e28cbf1

Merge branch 'master' into rebalanceXpackGroups

6d542ae

Merge branch 'master' into rebalanceXpackGroups

e284fba

Merge branch 'master' into rebalanceXpackGroups

c684716

Merge branch 'master' into rebalanceXpackGroups

2e853a3

YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 5, 2020

Rebalancing CI groups according to elastic#58930

4d9a3c3

Merge branch 'master' of github.com:elastic/kibana into pr/58930

d29643c

Merge branch 'master' into rebalanceXpackGroups

8bc82cf

Merge branch 'master' into rebalanceXpackGroups

9b7c92d

Merge branch 'master' into rebalanceXpackGroups

e0b2b58

spalger approved these changes Mar 12, 2020

View reviewed changes

LeeDr merged commit 69fd44e into elastic:master Mar 12, 2020

LeeDr mentioned this pull request Mar 12, 2020

[7.x] rebalance x-pack groups (#58930) #60050

Merged

LeeDr deleted the rebalanceXpackGroups branch March 12, 2020 22:39

Conversation

LeeDr commented Feb 28, 2020

Summary

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr commented Feb 29, 2020

Uh oh!

LeeDr commented Feb 29, 2020

Uh oh!

LeeDr commented Mar 2, 2020

Uh oh!

LeeDr commented Mar 2, 2020

Uh oh!

brianseeders commented Mar 3, 2020

Uh oh!

LeeDr commented Mar 3, 2020

Uh oh!

LeeDr commented Mar 4, 2020

Uh oh!

LeeDr commented Mar 4, 2020

Uh oh!

LeeDr commented Mar 11, 2020

Uh oh!

spalger commented Mar 11, 2020

Uh oh!

spalger commented Mar 11, 2020

Uh oh!

kibanamachine commented Mar 11, 2020

💚 Build Succeeded

History

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments