UI Metrics use findAll to retrieve all Saved Objects#59891
Merged
afharo merged 3 commits intoelastic:masterfrom Mar 12, 2020
Merged
UI Metrics use findAll to retrieve all Saved Objects#59891afharo merged 3 commits intoelastic:masterfrom
afharo merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/pulse (Team:Pulse) |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
/cc @elastic/kibana-platform maybe they think it's a good idea to provide a |
TinaHeiligers
requested changes
Mar 11, 2020
Contributor
TinaHeiligers
left a comment
TinaHeiligers
left a comment
There was a problem hiding this comment.
There are some copy-paste errors in index.test.ts. Other than that, nice use of recursion and thanks for cleaning up the use of any in telemetry_ui_metric_collector!
src/legacy/core_plugins/telemetry/server/collectors/ui_metric/index.test.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Mar 12, 2020
* UI Metrics use findAll to retrieve all Saved Objects * Rename test description Co-Authored-By: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 12, 2020
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
afharo
added a commit
that referenced
this pull request
Mar 13, 2020
* UI Metrics use findAll to retrieve all Saved Objects * Rename test description Co-Authored-By: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
lukeelmers
added
Feature:Telemetry
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the UI Metrics UsageCollection fetcher to use
findAllto paginate through all the Saved Objects stored when reporting to telemetry.Fixes #59883
Checklist
Delete any items that are not applicable to this PR.
For maintainers