[ML] Adding shared services to ml setup contract#59730
Merged
jgowdyelastic merged 7 commits intoelastic:masterfrom Mar 12, 2020
Merged
[ML] Adding shared services to ml setup contract#59730jgowdyelastic merged 7 commits intoelastic:masterfrom
jgowdyelastic merged 7 commits intoelastic:masterfrom
Conversation
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
jgowdyelastic
added
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
force-pushed
the
adding-shared-services-to-ml-setup-contract
branch
from
f8f15e7 to
752006a
Compare
peteharverson
approved these changes
Mar 11, 2020
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM. Just a question about the names of the providers we are exposing.
jgowdyelastic
force-pushed
the
adding-shared-services-to-ml-setup-contract
branch
from
71396fa to
a6a2655
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/date_nanos_job·ts.machine learning anomaly detection job on data set with date_nanos time field with count detector and model plot disabled job creation enables the dedicated index switchStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
walterra
reviewed
Mar 12, 2020
| anomalyDetectorsProvider(callAsCurrentUser: APICaller) { | ||
| return { | ||
| jobs(jobId?: string) { | ||
| isFullLicense(); |
Contributor
There was a problem hiding this comment.
Does this function call have a side effect like a throw or does this need change to be part of an if, in other files I see if (mlLicense.isFullLicense() === false) {.
walterra
reviewed
Mar 12, 2020
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 12, 2020
* [ML] Adding shared services to ml setup contract * adding data recognizer * typescripting js client * adding results service * code clean up * adding generic ml index search * making cloud optional
jgowdyelastic
added a commit
that referenced
this pull request
Mar 12, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 12, 2020
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add access to commonly used ML endpoints via our setup contract.
External plugins which are currently calling ML endpoints can now get access to the same data via these exposed functions on the server side of kibana.
All exposed functions contain license checks and will return an error if called with the incorrect license level.
Relates to #59735
Also refactors some routes to ensure they are all consistent in the way they require
callAsCurrentUser.Privilege checking is also required in these exposed functions, but will need to be added later once it's possible to have multiple reserved feature privileges so we can use kibana's capabilities. (#57637)