Add custom action to registry and show actions list in siem by YulNaumenko · Pull Request #58395 · elastic/kibana

YulNaumenko · 2020-02-24T19:10:36Z

elasticmachine · 2020-02-25T21:18:16Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…ing_example # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…ing_example # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx # x-pack/plugins/triggers_actions_ui/public/index.ts

…ing_example # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

pmuellr

code LGTM

mikecote

LGTM just a few questions and nits 👍

...lugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx

x-pack/plugins/triggers_actions_ui/public/plugin.ts

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts

...lugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx

…ing_example # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…ing_example # Conflicts: # x-pack/plugins/triggers_actions_ui/README.md # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx # x-pack/plugins/triggers_actions_ui/public/index.ts

kibanamachine · 2020-03-06T01:46:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f1a3070

History

💔 Build #30986 failed 59699b3
💔 Build #30921 failed dbea804
💔 Build #30162 failed 8f68603
💔 Build #30120 failed b040b9d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts

kibanamachine · 2020-03-07T01:48:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58395 or prevent reminders by adding the backport:skip label.

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - #58395 - #58964 - #60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - elastic#58395 - elastic#58964 - elastic#60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

## Summary Allow defining notifications that will trigger whenever the rule created new signals. Requires: - #58395 - #58964 - #60832 ![Screenshot 2020-03-02 at 10 19 18](https://user-images.githubusercontent.com/5188868/75662390-4fe8bf00-5c6f-11ea-943f-591367348b91.png) ![Screenshot 2020-03-02 at 10 13 00](https://user-images.githubusercontent.com/5188868/75662421-5e36db00-5c6f-11ea-9317-d158cddf4344.png) ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server) - [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>

Add custom action to registry and show actions list in siem

08e5d1f

YulNaumenko requested a review from a team as a code owner February 24, 2020 19:10

YulNaumenko self-assigned this Feb 24, 2020

YulNaumenko added 2 commits February 24, 2020 14:24

Exposed action form as reusable component

fc7d4f8

Fixed few small bugs

9df0157

YulNaumenko changed the title ~~[DRAFT} Add custom action to registry and show actions list in siem~~ [DRAFT] Add custom action to registry and show actions list in siem Feb 25, 2020

YulNaumenko added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Feb 25, 2020

YulNaumenko added Feature:Actions release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Feb 25, 2020

patrykkopycinski mentioned this pull request Mar 2, 2020

[SIEM] Add rule notifications #59004

Merged

7 tasks

YulNaumenko added the v7.7.0 label Mar 2, 2020

Fixed red ci

8f68603

YulNaumenko changed the title ~~[DRAFT] Add custom action to registry and show actions list in siem~~ Add custom action to registry and show actions list in siem Mar 4, 2020

YulNaumenko added 5 commits March 4, 2020 12:51

Fixed type checks

c4c7fc9

Merge remote-tracking branch 'upstream/master' into actions_ui_embedd…

dbea804

…ing_example # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx # x-pack/plugins/triggers_actions_ui/public/index.ts

Fixed failed tests

59699b3

pmuellr approved these changes Mar 5, 2020

View reviewed changes

mikecote approved these changes Mar 5, 2020

View reviewed changes

YulNaumenko added 7 commits March 5, 2020 09:58

Fixed due to comments

8ef41d1

Fixed type check errors

29b7b18

Fixed plugin check

7714f43

Rebalancing CI groups according to elastic#58930

4d9a3c3

Fixed merge issues

f1a3070

YulNaumenko merged commit 5ff13ad into elastic:master Mar 6, 2020

YulNaumenko mentioned this pull request Mar 6, 2020

[7.x] Add custom action to registry and show actions list in siem (#58395) #59515

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 7, 2020

YulNaumenko added backport:skip This PR does not require backporting backported and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom action to registry and show actions list in siem#58395

Add custom action to registry and show actions list in siem#58395
YulNaumenko merged 17 commits intoelastic:masterfrom
YulNaumenko:actions_ui_embedding_example

YulNaumenko commented Feb 24, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Feb 25, 2020

Uh oh!

pmuellr left a comment

Uh oh!

mikecote left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 6, 2020

Uh oh!

kibanamachine commented Mar 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

YulNaumenko commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 25, 2020

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 6, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Mar 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

YulNaumenko commented Feb 24, 2020 •

edited

Loading