Remove Kibana a11y guide in favor of EUI#57021
Merged
myasonik merged 6 commits intoelastic:masterfrom Feb 7, 2020
Merged
Conversation
myasonik
added
v8.0.0
release_note:skip
myasonik
commented
Feb 6, 2020
| id="veryImportantButton" | ||
| data-test-subj="clickMeButton" | ||
| > | ||
| <button id="veryImportantButton" data-test-subj="clickMeButton"> |
Contributor
Author
There was a problem hiding this comment.
My IDE automatically linted this file. I think it's fine to check it in like this but let me know if you want me to revert it.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
timroes
approved these changes
Feb 7, 2020
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Left a couple of typo (and aligned casing of React) suggestions on there. After that it looks all good to me!
Co-Authored-By: Tim Roes <mail@timroes.de>
Co-Authored-By: Tim Roes <mail@timroes.de>
Co-Authored-By: Tim Roes <mail@timroes.de>
Co-Authored-By: Tim Roes <mail@timroes.de>
Co-Authored-By: Tim Roes <mail@timroes.de>
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
myasonik
pushed a commit
that referenced
this pull request
Feb 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 9, 2020
…t-state * upstream/master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 9, 2020
* master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finally following up on #52478 and removing the Kibana a11y styleguide.