Skip to content

Comments

[docs] Fix spaces api example json#50411

Merged
gchaps merged 2 commits intoelastic:masterfrom
Conky5:fix-spaces-api-json
Feb 7, 2020
Merged

[docs] Fix spaces api example json#50411
gchaps merged 2 commits intoelastic:masterfrom
Conky5:fix-spaces-api-json

Conversation

@Conky5
Copy link
Contributor

@Conky5 Conky5 commented Nov 12, 2019

Summary

Make this example properly formatted json.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

Make this example properly formatted json.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@streamich
Copy link
Contributor

@elasticmachine merge upstream

@streamich streamich requested a review from a team February 7, 2020 11:01
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gchaps gchaps added the release_note:skip Skip the PR/issue when compiling release notes label Feb 7, 2020
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchaps gchaps added the v8.0.0 label Feb 7, 2020
@gchaps gchaps merged commit 12fcf01 into elastic:master Feb 7, 2020
@Conky5 Conky5 deleted the fix-spaces-api-json branch February 7, 2020 15:19
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 9, 2020
…t-state

* upstream/master: (96 commits)
  top nav ts arg support (elastic#56984)
  [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130)
  Add docs for alerting and action settings (elastic#57035)
  Add Test to Verify Endpoint App Landing Page (elastic#57129)
  Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126)
  chore(NA): removes use of parallel option in the terser minimizer (elastic#57077)
  [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972)
  Specifying valid licenses for the Graph feature (elastic#55911)
  [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948)
  [ML] DF Analytics creation: update schema definition for create route (elastic#56979)
  Remove Kibana a11y guide in favor of EUI (elastic#57021)
  [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329)
  [docs] Fix spaces api example json (elastic#50411)
  Add new config for filebeat index name (elastic#56920)
  [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796)
  Saved Objects testing (elastic#56965)
  Disabled categorization stats validation (elastic#57087)
  [Rollups] Server NP migration (elastic#55606)
  [Metrics UI] Limit group by selector to only 2 fields (elastic#56800)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 9, 2020
* master: (96 commits)
  top nav ts arg support (elastic#56984)
  [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130)
  Add docs for alerting and action settings (elastic#57035)
  Add Test to Verify Endpoint App Landing Page (elastic#57129)
  Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126)
  chore(NA): removes use of parallel option in the terser minimizer (elastic#57077)
  [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972)
  Specifying valid licenses for the Graph feature (elastic#55911)
  [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948)
  [ML] DF Analytics creation: update schema definition for create route (elastic#56979)
  Remove Kibana a11y guide in favor of EUI (elastic#57021)
  [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329)
  [docs] Fix spaces api example json (elastic#50411)
  Add new config for filebeat index name (elastic#56920)
  [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796)
  Saved Objects testing (elastic#56965)
  Disabled categorization stats validation (elastic#57087)
  [Rollups] Server NP migration (elastic#55606)
  [Metrics UI] Limit group by selector to only 2 fields (elastic#56800)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:Docs v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants