[Metrics-UI] Fix toolbar popover for metrics table row by phillipb · Pull Request #56796 · elastic/kibana

phillipb · 2020-02-04T20:45:58Z

Summary

When the popover opens, set overflow to hidden. Update the code to use hooks.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

elasticmachine · 2020-02-04T20:46:01Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

phillipb · 2020-02-05T16:21:32Z

@elasticmachine merge upstream

…cs-table-rows

afgomez

I wanna make sure I'm reviewing the right thing: this PR tackles the popover when the user clicks on an elemenent in the metrics table, right?

afgomez · 2020-02-06T09:19:42Z

x-pack/legacy/plugins/infra/public/components/nodes_overview/table.tsx

-              <EuiButtonEmpty onClick={handleClick}>{value}</EuiButtonEmpty>
+export const TableView = (props: Props) => {
+  const { nodes, options, formatter, currentTime, nodeType } = props;
+  const [isPopoverOpen, setIsPopoverOpen] = useState<string[]>([]);


[nit] I see this was the previous name, but I'd rename this to openPopovers or similar. My first reaction with the current name is that:

There's only one popover

The variable is a boolean

afgomez · 2020-02-06T09:26:33Z

x-pack/legacy/plugins/infra/public/components/nodes_overview/table.tsx

+
+  const closePopoverFor = useCallback(
+    (id: string) => () => {
+      setIsPopoverOpen([...isPopoverOpen, id]);


I think we can drop this line

…metrics-table-rows

phillipb · 2020-02-06T17:59:05Z

I wanna make sure I'm reviewing the right thing: this PR tackles the popover when the user clicks on an elemenent in the metrics table, right?

@afgomez Yeah, that's the right one

elasticmachine · 2020-02-06T19:23:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e4d45b5

History

💚 Build #24633 succeeded 0efc4e5
💔 Build #24433 failed bc47743

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afgomez

Ship it 🎉!

* Disable scroll when popover is open. Switch to hooks * Remove unused prop * UseEffect to update styles * Remove ununsed import * Rename variables for clarity Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

phillipb · 2020-02-07T16:40:52Z

@afgomez thanks for the review!

* Disable scroll when popover is open. Switch to hooks * Remove unused prop * UseEffect to update styles * Remove ununsed import * Rename variables for clarity Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…t-state * upstream/master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...

* master: (96 commits) top nav ts arg support (elastic#56984) [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130) Add docs for alerting and action settings (elastic#57035) Add Test to Verify Endpoint App Landing Page (elastic#57129) Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126) chore(NA): removes use of parallel option in the terser minimizer (elastic#57077) [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972) Specifying valid licenses for the Graph feature (elastic#55911) [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948) [ML] DF Analytics creation: update schema definition for create route (elastic#56979) Remove Kibana a11y guide in favor of EUI (elastic#57021) [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329) [docs] Fix spaces api example json (elastic#50411) Add new config for filebeat index name (elastic#56920) [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796) Saved Objects testing (elastic#56965) Disabled categorization stats validation (elastic#57087) [Rollups] Server NP migration (elastic#55606) [Metrics UI] Limit group by selector to only 2 fields (elastic#56800) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) ...

phillipb added 3 commits February 4, 2020 14:37

Disable scroll when popover is open. Switch to hooks

198e932

Remove unused prop

46c6167

UseEffect to update styles

c3db1ec

phillipb added release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 labels Feb 4, 2020

phillipb requested a review from a team as a code owner February 4, 2020 20:45

Remove ununsed import

bc47743

elasticmachine and others added 2 commits February 5, 2020 11:21

Merge branch 'master' into metrics-table-rows

0efc4e5

Merge branch 'master' of https://github.com/elastic/kibana into metri…

3d6a9ee

…cs-table-rows

afgomez self-requested a review February 6, 2020 09:49

afgomez reviewed Feb 6, 2020

View reviewed changes

phillipb added 2 commits February 6, 2020 11:53

Merge branch 'metrics-table-rows' of github.com:phillipb/kibana into …

91c7bfc

…metrics-table-rows

Rename variables for clarity

e4d45b5

elastic deleted a comment from kibanamachine Feb 6, 2020

afgomez changed the title ~~[Metrics-UI] Fix toolbar hover for metrics table row~~ [Metrics-UI] Fix toolbar popover for metrics table row Feb 7, 2020

afgomez approved these changes Feb 7, 2020

View reviewed changes

phillipb merged commit dd8ccc4 into elastic:master Feb 7, 2020

phillipb mentioned this pull request Feb 7, 2020

[7.x] [Metrics-UI] Fix toolbar popover for metrics table row (#56796) #57111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[Metrics-UI] Fix toolbar popover for metrics table row#56796

[Metrics-UI] Fix toolbar popover for metrics table row#56796
phillipb merged 8 commits intoelastic:masterfrom
phillipb:metrics-table-rows

phillipb commented Feb 4, 2020

Uh oh!

elasticmachine commented Feb 4, 2020

Uh oh!

phillipb commented Feb 5, 2020

Uh oh!

afgomez left a comment

Uh oh!

afgomez Feb 6, 2020

Uh oh!

afgomez Feb 6, 2020

Uh oh!

phillipb Feb 6, 2020

Uh oh!

phillipb commented Feb 6, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Feb 6, 2020

Uh oh!

afgomez left a comment

Uh oh!

phillipb commented Feb 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

phillipb commented Feb 4, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Feb 4, 2020

Uh oh!

phillipb commented Feb 5, 2020

Uh oh!

afgomez left a comment

Choose a reason for hiding this comment

Uh oh!

afgomez Feb 6, 2020

Choose a reason for hiding this comment

Uh oh!

afgomez Feb 6, 2020

Choose a reason for hiding this comment

Uh oh!

phillipb Feb 6, 2020

Choose a reason for hiding this comment

Uh oh!

phillipb commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

afgomez left a comment

Choose a reason for hiding this comment

Uh oh!

phillipb commented Feb 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

phillipb commented Feb 6, 2020 •

edited

Loading