Retry ES API calls that fail with 410/Gone to prevent kibana from crashing at startup#56950
Merged
rudolf merged 2 commits intoelastic:masterfrom Feb 7, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
approved these changes
Feb 6, 2020
Contributor
joshdover
approved these changes
Feb 6, 2020
Contributor
Author
|
@bhavyarm It was by coincidence that we noticed it because an ES Proxy was incorrectly configured which would cause it to always return 410 status codes to any requests. The only way to test this would be to point Kibana to an proxy which allows us to control the response status codes. I've used a tool like MITMProxy to do something like this before https://docs.mitmproxy.org/stable/addons-scripting/ if we don't have any existing tools let me know if I can help set something up. |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/uptime/server/lib/helper/__test__.getHistogramIntervalFormatted specifies the interval necessary to divide a given timespan into equal buckets, rounded to the nearest integer, expressed in msStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Feb 7, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Feb 7, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rudolf
added a commit
that referenced
this pull request
Feb 7, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 7, 2020
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...
rudolf
added a commit
that referenced
this pull request
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For Saved Object migrations, ignore ES API calls that fail with 410/Gone status code. This prevents Kibana from crashing on startup under the following conditions:
nodes.info.Checklist
Delete any items that are not applicable to this PR.
For maintainers