Use i18n titles for field formatters, human names for numeral locales#56348
Merged
wylieconlon merged 3 commits intoelastic:masterfrom Feb 6, 2020
Merged
Use i18n titles for field formatters, human names for numeral locales#56348wylieconlon merged 3 commits intoelastic:masterfrom
wylieconlon merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
|
Pinging @elastic/kibana-localization (Team:Localization) |
wylieconlon
added
the
release_note:skip
lukeelmers
reviewed
Jan 30, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Thanks for doing this @wylieconlon! Code all LGTM; I just had one comment regarding the structure of the i18n IDs.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukeelmers
approved these changes
Feb 6, 2020
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Updates LGTM, thanks!
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Feb 6, 2020
…elastic#56348) * Use i18n titles for field formatters, human names for numeral locales * Rename i18n IDs, these are not currently translated
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 7, 2020
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...
lukeelmers
added
Project:i18n
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field formatters have titles which are used in the format editing UI, but were not using i18n. I will also be using these titles in Lens here: #56253
Also, numeral locales were previously using codes like
es,en-gbinstead of human-readable names likeFrench (Canada). These names are not i18n, but are still an improvement over the locale codes.