Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 by kertal · Pull Request #56408 · elastic/kibana

kertal · 2020-01-30T17:11:10Z

Summary

Migrate the following dependencies to kibana_legacy while keeping them compatible with the old platform by importing static functions from NP.

"Private" ui/private/private
Promises ui/promises/promises
migrateLegacyQuery ui/utils/migrate_legacy_query
ui/compat
ui/legacy_compat && parts of ui/notify
ui/directives/watch_multi/watch_multi
ui/accessibility/kbn_accessible_click
ui/directives/listen/listen

Part of #50670

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

…-30-move_static_code_deps_into_kibana_legacy

elasticmachine · 2020-02-05T12:10:35Z

Pinging @elastic/kibana-app (Team:KibanaApp)

azasypkin

Changes in Spaces plugin LGTM.

flash1293

Looks mostly good, left some nits. Great how little stuff there's still left in the legacy imports

flash1293 · 2020-02-05T15:21:59Z

src/plugins/kibana_legacy/public/angular/angular_config.tsx

@@ -374,21 +383,21 @@ const $setupUrlOverflowHandling = (newPlatform: CoreStart, isLocalAngular: boole
    try {


Doesn't have to happen in this PR, but we should probably pull the gist of these helpers out of the angular context and put them into generic helpers (e.g. for the ui capability redirect or the url overflow redirect)

...y/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout.test.tsx

flash1293 · 2020-02-05T15:30:29Z

src/plugins/kibana_legacy/public/utils/index.ts

+// @ts-ignore
+export { PrivateProvider } from './private';
+// @ts-ignore
+export { registerListenEventListener } from './register_listen_event_listener';


On second thought - is migrate_legacy_query more of a data plugin responsibility? Not sure how to handle this. Can also be handled in a separate issue

about migrate_legacy_query:
Creates a standardized query object from old queries that were either strings or pure ES query DSL

Dear @elastic/kibana-app-arch 🏹 what do you think, should it be migrated to data

flash1293 · 2020-02-05T15:33:21Z

src/legacy/core_plugins/kibana/public/visualize/legacy_imports.ts

@@ -41,33 +41,31 @@ export { PersistedState } from 'ui/persisted_state';

 export { npSetup, npStart } from 'ui/new_platform';
 export { IPrivate } from 'ui/private';


The code for private is moved, lets also move the type and reference it via re-export.

thx! will clean up!

crob611

Canvas change is good 👍

flash1293

LGTM, thanks for the cleanup 👍

elasticmachine · 2020-02-07T09:02:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a3f97b4

History

💚 Build #24916 succeeded b6c6fa3
💔 Build #24856 failed b8c6b27
💔 Build #24843 failed 484af2b
💔 Build #24837 failed ff6e2a6
💔 Build #24831 failed d6604a1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…y plugin, part 1 (elastic#56408) * Migrate PromiseServiceCreator * Migrate migrateLegacyQuery * Migrate watch_multi decorator * Migrate call_after_bindings_workaround * Migrate configureAppAngularModule, ensureDefaultIndexPattern and deps * Migrate kbn_accessible_clicks * Migrate PrivateProvider * Migrate registerListenEventListener * Adapt i18n files

…y plugin, part 1 (#56408) (#57095) * Migrate PromiseServiceCreator * Migrate migrateLegacyQuery * Migrate watch_multi decorator * Migrate call_after_bindings_workaround * Migrate configureAppAngularModule, ensureDefaultIndexPattern and deps * Migrate kbn_accessible_clicks * Migrate PrivateProvider * Migrate registerListenEventListener * Adapt i18n files

…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...

Move PromiseServiceCreator to kibana_legacy, keep placeholder

5f77f47

kertal self-assigned this Jan 30, 2020

kertal added 2 commits January 31, 2020 06:11

Fix types

b7289cc

Merge master / Fix conflicts

c7269b6

kertal added the Feature:NP Migration label Jan 31, 2020

kertal added 14 commits January 31, 2020 16:16

Migrate migrateLegacyQuery

e41c85c

Migrate watch_multi decorator

ef45e93

Migrate watch_multi decorator II

f12dad8

Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…

8ebae78

…-30-move_static_code_deps_into_kibana_legacy

Migrate call_after_bindings_workaround

fd2f0ae

Migrate configureAppAngularModule, ensureDefaultIndexPattern and deps

896127e

Restore ui/notify banners

ac67728

Add banners, fix import path

75e76dd

Fix i18n

820bbcf

Migrate kbn_accessible_clicks

499f3a8

Fix app_redirect jest test

a52503b

Migrate PrivateProvider

926a01c

Migrate registerListenEventListener

7c772d8

Merge upstream/master and fix conflicts

2b491da

kertal changed the title ~~Kibana app migration: Move static code dependencies into kibana_legacy plugin~~ Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 Feb 4, 2020

kertal added 5 commits February 4, 2020 22:20

Merge upstream/master, fix conflicts

04e5b73

Minor adaptions

f48f8d4

Fix i18n

4fccc96

Optimize imports

7e20c19

Minor fixes

0be548a

kertal added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Feb 5, 2020

kertal added v8.0.0 v7.7.0 labels Feb 5, 2020

kertal marked this pull request as ready for review February 5, 2020 12:11

kertal requested a review from a team February 5, 2020 12:11

kertal requested review from a team as code owners February 5, 2020 12:11

azasypkin approved these changes Feb 5, 2020

View reviewed changes

kertal added the release_note:skip Skip the PR/issue when compiling release notes label Feb 5, 2020

flash1293 reviewed Feb 5, 2020

View reviewed changes

kertal added 6 commits February 6, 2020 07:43

Migrate IPrivate

d6604a1

undo ToastNotification changes / add deprecated text

ff6e2a6

Merge upstream/master, fix conflicts

484af2b

Remove duplicate import of migrateLegacyQuery

b8c6b27

Fix i18n

c3d4f20

Merge upstream/master, fix conflicts

b6c6fa3

crob611 approved these changes Feb 6, 2020

View reviewed changes

kertal requested a review from flash1293 February 6, 2020 14:58

flash1293 approved these changes Feb 6, 2020

View reviewed changes

Merge upstream/master, fix conflicts

a3f97b4

elastic deleted a comment from kibanamachine Feb 7, 2020

kertal merged commit c4fe6ec into elastic:master Feb 7, 2020

kertal mentioned this pull request Feb 7, 2020

[7.x] Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (#56408) #57095

Merged

		@@ -374,21 +383,21 @@ const $setupUrlOverflowHandling = (newPlatform: CoreStart, isLocalAngular: boole
		try {

		@@ -41,33 +41,31 @@ export { PersistedState } from 'ui/persisted_state';

		export { npSetup, npStart } from 'ui/new_platform';
		export { IPrivate } from 'ui/private';

Comments

Conversation

kertal commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 5, 2020

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flash1293 Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

kertal Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

kertal Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

kertal Feb 6, 2020

Choose a reason for hiding this comment

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kertal commented Jan 30, 2020 •

edited

Loading